-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test(status): increasing test coverage of status module #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@seanmonstar I am done with adding tests in status.rs. I see that you use helper macros in other files, a simple function seems to do the trick here. Let me know if you want me to change/cleanup the code. |
|
Excellent! |
src/status.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preferred style is a space after the colon, such as num: u16.
|
Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:
Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
|
Changes Unknown when pulling 4ba3033 on winding-lines:more-tests into * on hyperium:master*. |
|
Looks like this contains a commit from master. Would you rebase? While On Sun, May 24, 2015, 8:06 AM Coveralls notifications@github.com wrote:
|
|
Yeah, I did a git pull from upstream master and something unexpected happened :-) I did a rebase, let me know if the code/history are in the desired state now. |
|
Perfect, thank you! |
test(status): increasing test coverage of status module
No description provided.