Skip to content

Conversation

@winding-lines
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.46%) to 86.09% when pulling f705bb6 on winding-lines:more-tests into 5747792 on hyperium:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.17%) to 86.8% when pulling 7a38751 on winding-lines:more-tests into 5747792 on hyperium:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.57%) to 88.21% when pulling 284ee08 on winding-lines:more-tests into 5747792 on hyperium:master.

@winding-lines
Copy link
Contributor Author

@seanmonstar I am done with adding tests in status.rs. I see that you use helper macros in other files, a simple function seems to do the trick here. Let me know if you want me to change/cleanup the code.

@seanmonstar
Copy link
Member

Excellent!

src/status.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preferred style is a space after the colon, such as num: u16.

@GitCop
Copy link

GitCop commented May 24, 2015

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

  • Commit: af831f4
    • Commits must be in the following format: %{type}(%{scope}): %{description}
  • Commit: 4ba3033
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4ba3033 on winding-lines:more-tests into * on hyperium:master*.

@seanmonstar
Copy link
Member

Looks like this contains a commit from master. Would you rebase? While
doing so, you could squash the commits into 1, using 'git rebase -i
upstream/master'.

On Sun, May 24, 2015, 8:06 AM Coveralls notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/2638398

Changes Unknown when pulling 4ba3033
4ba3033
on winding-lines:more-tests
into * on hyperium:master*.


Reply to this email directly or view it on GitHub
#544 (comment).

@winding-lines
Copy link
Contributor Author

Yeah, I did a git pull from upstream master and something unexpected happened :-) I did a rebase, let me know if the code/history are in the desired state now.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.71%) to 88.07% when pulling 795ee9f on winding-lines:more-tests into 69aa25f on hyperium:master.

@seanmonstar
Copy link
Member

Perfect, thank you!

seanmonstar added a commit that referenced this pull request May 24, 2015
test(status): increasing test coverage of status module
@seanmonstar seanmonstar merged commit 221f2c9 into hyperium:master May 24, 2015
@winding-lines winding-lines deleted the more-tests branch May 24, 2015 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants