Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DefaultIsmInterchainGasPaymaster in checker & govern #1926

Merged
merged 4 commits into from Mar 13, 2023

Conversation

tkporter
Copy link
Collaborator

Description

Drive-by changes

  • Some fixes in the wake of the sdk refactor, e.g.:
    • if some tx params like maxPriorityFeePerGas or maxFeePerGas were specified when we estimate gas, it can fail if the balance of the sender is insufficient. For cases where we want to estimate gas from the owner multisig which may not have native tokens, this caused issues.
    • We should've been passing the from address into the MultiProvider.estimateGas fn as a separate param

Related issues

n/a

Backward compatibility

Are these changes backward compatible?

Yes

Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?

None

Testing

What kind of testing have these changes undergone?

Ran & proposed some txs on mainnet to update the destination gas overheads

@tkporter tkporter requested review from yorhodes and asaj March 13, 2023 14:03
@tkporter tkporter enabled auto-merge (squash) March 13, 2023 16:25
@github-actions
Copy link
Contributor

Solidity Coverage Report

Coverage after merging trevor/default-ism-igp-checkr into main will be
79.54% 0.00%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts
   Create2Factory.sol0%100%0%0%101–102, 110, 112, 33, 58, 64–65, 77–78, 98
   GasRouter.sol73.33%100%50%100%
   HyperlaneConnectionClient.sol52.50%100%43.75%58.33%100–101, 131, 160, 164–165, 85–86, 98–99
   Mailbox.sol77.61%100%48%95.24%231, 275
   OwnableMulticall.sol50%100%40%66.67%16
   PausableReentrancyGuard.sol95.24%100%90%100%
   Router.sol80%100%69.57%88.89%46, 53, 64
   ValidatorAnnounce.sol76%100%42.86%88.89%55–56
contracts/igps
   InterchainGasPaymaster.sol87.23%100%68.42%100%
   OverheadIgp.sol63.16%100%45.45%87.50%45
contracts/igps/gas-oracles
   StorageGasOracle.sol75%100%50%100%
contracts/isms
   MultisigIsm.sol82%100%51.52%97.01%337, 339
contracts/libs
   Call.sol43.18%100%28.57%50%101, 109, 117, 125, 133, 141, 33, 58–63, 78, 90
   EnumerableMapExtended.sol36.36%100%28.57%50%45, 61, 69–70
   Merkle.sol91.04%100%50%98.25%44
   Message.sol60.61%100%45.45%90.91%109
   MinimalProxy.sol66.67%100%50%100%
   MultisigIsmMetadata.sol70.59%100%50%100%
   TypeCasts.sol30.77%100%33.33%28.57%11–13, 17–18
   ValidatorAnnouncements.sol75%100%50%100%
contracts/middleware
   InterchainAccountRouter.sol54.29%100%33.33%70%103, 111, 45, 47–48, 64
   InterchainCallMessage.sol46.43%100%35.71%57.14%42, 50–51, 62, 70–71
   InterchainQueryRouter.sol70.83%100%33.33%83.33%101, 119, 62
contracts/middleware/liquidity-layer
   LiquidityLayerRouter.sol73.08%100%40%93.75%34
contracts/middleware/liquidity-layer/adapters
   CircleBridgeAdapter.sol35.59%100%17.65%42.86%169, 176, 178, 185, 191–192, 194–195, 200–201, 203, 211–212, 214–215, 221–222, 224, 58–59, 75, 77–78, 81
   PortalAdapter.sol52.27%100%20%68.97%192, 199, 201, 52–53, 69, 71–73

@tkporter tkporter merged commit 20e6857 into main Mar 13, 2023
12 checks passed
@tkporter tkporter deleted the trevor/default-ism-igp-checkr branch March 13, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants