Google Cloud Storage CheckpointSyncer implementation#3156
Google Cloud Storage CheckpointSyncer implementation#3156daniel-savu merged 15 commits intohyperlane-xyz:mainfrom
Conversation
|
|
hey Ivan @35359595 - @daniel-savu will review again shortly. thank you for your patience! |
|
@35359595 looks like |
Some doc tests were missing imports after comment fixes applied. Fixed now. |
|
@daniel-savu please re-run the CI for this. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3156 +/- ##
=======================================
Coverage 67.65% 67.65%
=======================================
Files 99 99
Lines 1014 1014
Branches 106 106
=======================================
Hits 686 686
Misses 284 284
Partials 44 44
|
|
When I try to use it, it keeps saying "Unknown checkpoint syncer type". I see that although Is it still WIP to support Google Cloud? Or how do you specify the Checkpoint Syncer settings to use GCS bucket for storage? |
|
hi @sapph1re saw your discord message too, we're happy to create a bounty to successfully implement this if you're interested |
Ok let's do that |
### Description Fixing the issue I described [earlier](#3156 (comment)) where the usage of GCS as an alternative to AWS although supported by Hyperlane Agents, in practice didn't work because the settings still didn't accept "gcs" as a checkpoint syncer type. ### Backward compatibility Yes ### Testing Manual
### Description Fixing the issue I described [earlier](hyperlane-xyz/hyperlane-monorepo#3156 (comment)) where the usage of GCS as an alternative to AWS although supported by Hyperlane Agents, in practice didn't work because the settings still didn't accept "gcs" as a checkpoint syncer type. ### Backward compatibility Yes ### Testing Manual
Description
GSC builder and implementer classes;
Documentation comments;
Examples;
Anonymous test on public bucket access;
Drive-by changes
cargo docbuild fixes:';<>;Related issues
Fixes #2242 Part 1
Backward compatibility
Yes
Testing
Unit Tests