Propose mirgration of codebase from JS to TS #11
Conversation
Migration of codebase from JS to TS BREAKING CHANGE: Use of TS
.travis.yml
Outdated
| @@ -0,0 +1,19 @@ | |||
| language: node_js | |||
There was a problem hiding this comment.
Why travis? Other Iroha projects are using circle-ci2.
There was a problem hiding this comment.
Sorry, i didn't know you already use circle-ci2. I would try to change it to be like other one.
package.json
Outdated
| "bugs": { | ||
| "url": "https://github.com/soramitsu/iroha-javascript/issues" | ||
| }, | ||
| "homepage": "https://github.com/soramitsu/iroha-javascript#readme", |
There was a problem hiding this comment.
https://github.com/hyperledger/iroha-javascript#readme might be better
package.json
Outdated
| "author": "", | ||
| "license": "Apache-2.0", | ||
| "bugs": { | ||
| "url": "https://github.com/soramitsu/iroha-javascript/issues" |
There was a problem hiding this comment.
https://github.com/hyperledger/iroha-javascript/issues might be better
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/soramitsu/iroha-javascript.git" |
There was a problem hiding this comment.
→ "url": "git+https://github.com/hyperledger/iroha-javascript.git"
|
Thank you for your contribution!! Overall, this looks okay. I guess there is just the question on whether we want to switch to typescript from JS. I think more people than me should comment on this, so let's see what people think. |
theofilis
force-pushed
the
master
branch
3 times, most recently
from
d5f4f22 to
0c664da
Compare
|
In this article you could find reasons why it's good idea to adopt Typescript https://medium.freecodecamp.com/when-should-i-use-typescript-311cb5fe801b#.xxvrfzoa6 |
|
I personally like Typescript. I think we can have a decision today. |
4 participants
Hi,
Project Iroha is very interesting thus I want to contribute my coding skill in yours javascript library.
I migrate your project to Typescript I use the latest trends on library development with Typescript as they are proposed here