rework token/services/db/sql/common/identity.go #1167 #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecaro
force-pushed
the
1167-rework-tokenservicesdbsqlcommonidentitygo
branch
2 times, most recently
from
c3917f3 to
b823b49
Compare
| Format() | ||
| logger.Debug(query, args) | ||
|
|
||
| _, err = db.writeDB.Exec(query, args...) |
Contributor
Author
There was a problem hiding this comment.
cannot pass it because who is receive this struct doesn't have a context :(
| From(q.Table(db.table.KeyStore)). | ||
| Where(cond.Eq("key", key)). | ||
| Format(db.ci) | ||
| raw, err := common.QueryUnique[[]byte](db.readDB, query, args...) |
alexandrosfilios
approved these changes
Jul 30, 2025
Contributor
alexandrosfilios
left a comment
alexandrosfilios
left a comment
There was a problem hiding this comment.
LGTM modulo comments
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
adecaro
force-pushed
the
1167-rework-tokenservicesdbsqlcommonidentitygo
branch
from
433f606 to
2a94f7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: It introduces the KeyStoreDB to replace the FSC's KVS as keystore for the BCCSP.
This way, we can better control the behaviour of this component.