UI sample for message broadcast #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Removed a few things that will come back when private data is ready. For now, this can actually show all received messages and send a new broadcast. Still to add: dynamically show new messages (instead of needing a refresh), show two parties side-by-side (instead of only one party). Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Very rudimentary refresh mechanism. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
shorsher
approved these changes
Jun 9, 2021
| "react": "^17.0.2", | ||
| "react-dom": "^17.0.2", | ||
| "react-scripts": "4.0.3", | ||
| "reconnecting-websocket": "^4.4.0", |
private-data-transfer-ui/src/App.tsx
Outdated
| import { useCallback, useEffect, useRef, useState } from 'react'; | ||
| import { FireFly, FireFlyData, FireFlyMessage } from './firefly'; | ||
| import ReconnectingWebsocket from 'reconnecting-websocket'; | ||
| import './App.css'; |
There was a problem hiding this comment.
with the use of makeStyles, we can get rid of App.css
| @@ -0,0 +1 @@ | |||
| /// <reference types="react-scripts" /> | |||
There was a problem hiding this comment.
I would just leave this out and add it to your .gitignore, it gets autogenerated by CRA each time but is useless
https://stackoverflow.com/questions/53527763/create-react-app-typescript-auto-generating-react-app-env-d-ts-in-src-director
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.