Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need clarification: for 'change_sig' attribute in 0160-Connections Response message #362

Closed
naman1303 opened this issue Dec 26, 2019 · 6 comments

Comments

@naman1303
Copy link

naman1303 commented Dec 26, 2019

In the Response Processing section of Connection Response step, below is mentioned:

When the invitee receives the response message, they will verify the change_sig provided.

But the attribute 'change_sig' is not mentioned anywhere else.
Is it a typo (where it actually meant 'sig_data' or 'connection~sig')?
Please correct it or add some detail to it otherwise.

@swcurran
Copy link
Member

swcurran commented Jan 7, 2020

The specific reference is to this section of the 0160-Connections RFC.

@andrewwhitehead @tmarkovski - can either one of you take a read of that section, and perhaps the full Connection Response section? Is it accurate with what has been implemented and is working?

Thanks

@swcurran swcurran changed the title Need clarification: for 'change_sig' attribute Need clarification: for 'change_sig' attribute in 0160-Connections Response message Jan 7, 2020
@swcurran
Copy link
Member

swcurran commented Jan 9, 2020

Per the Aries WG call on 20200108, @tmarkovski volunteered to review the RFC and respond to this question. Tomislav - I'm happy to do the RFC update if you want to summarize any needed changes.

@tmarkovski
Copy link
Member

It should be sig_data. Submitted PR

@swcurran
Copy link
Member

swcurran commented Jan 9, 2020 via email

@tmarkovski
Copy link
Member

Rest of the section looks good.

@swcurran
Copy link
Member

swcurran commented Jan 9, 2020

Thanks @tmarkovski - closing this issue as resolved. The associated PR has been merged.

@swcurran swcurran closed this as completed Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants