adds deprecation notices for clique #1889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
macfarla
reviewed
Dec 3, 2025
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
technically we only deprecated Clique mining in 25.12.0 - otherwise LGTM
Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net>
macfarla
reviewed
Dec 3, 2025
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
think for other deprecations like this we don't link to the changelog, I'd keep it simple.
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net>
m4sterbunny
force-pushed
the
1884-clique-mining
branch
from
e87fda1 to
1a14212
Compare
Signed-off-by: m4sterbunny <harrie.bickle-ext@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue(s) fixed
Fixes #1884
Preview