New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement liveness check #4007
Comments
That's typically all a liveness endpoint does. Something context dependent such as reporting if the node is in sync or not is usually a separate health check endpoint. Both are useful in different situations (ie you want a docker container to consider itself started once the liveness check passes - it would time out long before the node finishes syncing and the health check returns OK). |
I think there's potential for some ordering issues here, the I think the main scenario that would be helpful is around graceful shutdowns. At the moment when you stop besu you may still be serving http requests. Ideally you'd want to indicate that you're shutting down on the LivenessCheck, this would allow k8s/whatever to remove the instance from rotation and direct requests elsewhere, then you could gracefully shutdown besu as normal (let me know if you want me to elaborate more). |
We discussed this a while ago among the developers and the reason why we always return We have updated the documentation of the endpoint to make this behavior clear: https://besu.hyperledger.org/en/stable/public-networks/how-to/use-besu-api/json-rpc/?h=liveness#liveness |
Besu offers a liveness RPC endpoint. But the endpoint does not do any check and just returns that is is
UP
no matter what: source code of the check.We need to define what a proper liveness check looks like and implement it.
The text was updated successfully, but these errors were encountered: