Update Gradle to 6.0, support Java 13 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade gradle to 6.0. * This is needed as Gradle 5.x did not support Java 13 * Jacoco needed a version upgrade to support Java 13 * upgrade errorprone to 1.1.1 to fix some breaks * Another errorprone check is broken in 13 * The 'Finally' Errorprone check is only broken in Java 12 Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
usmansaleem
reviewed
Nov 10, 2019
| @@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| zipStoreBase=GRADLE_USER_HOME | |||
| zipStorePath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.0-all.zip | |||
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> # Conflicts: # build.gradle
rain-on
pushed a commit
to rain-on/besu
that referenced
this pull request
Nov 11, 2019
Upgrade Gradle to 6.0. * This is needed as Gradle 5.x did not support Java 13 * Jacoco needed a version upgrade to support Java 13 * Upgrade Errorprone to fix some breaks * Another Errorprone check is broken in 13 * The 'Finally' Errorprone check is only broken in Java 12 * JMH needed a version upgrade and a new build flag * Switch to bin distribution for smaller builds Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
rain-on
pushed a commit
to rain-on/besu
that referenced
this pull request
Nov 11, 2019
Upgrade Gradle to 6.0. * This is needed as Gradle 5.x did not support Java 13 * Jacoco needed a version upgrade to support Java 13 * Upgrade Errorprone to fix some breaks * Another Errorprone check is broken in 13 * The 'Finally' Errorprone check is only broken in Java 12 * JMH needed a version upgrade and a new build flag * Switch to bin distribution for smaller builds Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade gradle to 6.0.
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>