Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ghcr.io instead of docker hub to store and release the docker images #1780

Closed
sownak opened this issue Dec 14, 2021 · 7 comments · Fixed by #1819
Closed

Use ghcr.io instead of docker hub to store and release the docker images #1780

sownak opened this issue Dec 14, 2021 · 7 comments · Fixed by #1819
Assignees
Labels
CI Establish Continuous Integration to enable more frequent & higher quality merges good-first-issue Good for newcomers
Projects

Comments

@sownak
Copy link
Contributor

sownak commented Dec 14, 2021

Description

As a developer I want to store Bevel images at ghcr.io/hyperledger/bevel- so that I can integrate using Github Actions and remove dependency on Docker Hub

Update the build images github actions workflow at .github/workflows/docker_build.yml

Acceptance Criteria

  1. baf-build Images/packages available on gchr.io
  2. corda os images available on ghcr.io
@sownak sownak added good-first-issue Good for newcomers CI Establish Continuous Integration to enable more frequent & higher quality merges labels Dec 14, 2021
@semusings
Copy link

semusings commented Dec 16, 2021

I am interested to contribute to this. Can I do ?

@suvajit-sarkar suvajit-sarkar changed the title Use gchr.io instead of docker hub to store and release the docker images Use ghcr.io instead of docker hub to store and release the docker images Dec 20, 2021
@suvajit-sarkar suvajit-sarkar added this to To do in Sprint 56 Jan 3, 2022
@surabhi-dudhediya
Copy link
Contributor

I would like to work on this issue

@TonyRowntree
Copy link
Member

Spoke with @surabhi-dudhediya and I am taking this now

@TonyRowntree
Copy link
Member

image

by default when you fork a repo the permission for the github token is read only, the permissions can be elevated by a user with admin rights. It could be possible to not require elevated rights if the user that merges the PR has admin rights to the repo but that is something that we would need to test. Additionally, admins can set permissions for the githubToken on a job basis meaning that only the jobs that need elevated permissions can be granted them

Source for info: https://docs.github.com/en/actions/security-guides/automatic-token-authentication

@TonyRowntree
Copy link
Member

Based on the above, when I tried to test the feature on my fork I received an authorization error seen below.

image

@TonyRowntree
Copy link
Member

Turns out the above is an issue with how the tags work when pushing to ghcr - I have managed to push the packages to my personal fork. Updating the commit with the working code.

@TonyRowntree
Copy link
Member

Updated commit - ready for review

@suvajit-sarkar suvajit-sarkar moved this from To do to In progress in Sprint 56 Jan 10, 2022
@suvajit-sarkar suvajit-sarkar moved this from In progress to Review in progress in Sprint 56 Jan 10, 2022
@suvajit-sarkar suvajit-sarkar linked a pull request Jan 28, 2022 that will close this issue
Sprint 56 automation moved this from Review in progress to Done Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Establish Continuous Integration to enable more frequent & higher quality merges good-first-issue Good for newcomers
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants