Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web3] Experimental RPC #1238

Merged
merged 8 commits into from Sep 26, 2019

Conversation

@gregdhill
Copy link
Contributor

commented Sep 3, 2019

Signed-off-by: Gregory Hill greg.hill@monax.io

Adds

  • Web3 Provider (OpenRPC Compliant)
  • RLP Encoding / Decoding Library
  • Secp256k1 Signature To PubKey

Fixes

  • Secp256k1 (adopts Ethereum style addresses / hashing)

Changed

  • CallTx can now do a simple fund transfer to an account with no code
@gregdhill gregdhill force-pushed the gregdhill:web3 branch from 9aa7711 to bc4932d Sep 3, 2019
@gregdhill gregdhill force-pushed the gregdhill:web3 branch 2 times, most recently from 44f0c9b to 8ca5214 Sep 13, 2019
@gregdhill gregdhill force-pushed the gregdhill:web3 branch 2 times, most recently from 9138cd5 to 4b45db5 Sep 18, 2019
@gregdhill gregdhill marked this pull request as ready for review Sep 19, 2019
@gregdhill gregdhill changed the title WIP: experimental web3 rpc [Web3] Experimental RPC Sep 19, 2019
@gregdhill gregdhill changed the base branch from develop to master Sep 19, 2019
protobuf/payload.proto Outdated Show resolved Hide resolved
encoding/rlp/rlp.go Show resolved Hide resolved
encoding/rlp/rlp.go Outdated Show resolved Hide resolved
encoding/rlp/binary.go Outdated Show resolved Hide resolved
encoding/rlp/rlp.go Outdated Show resolved Hide resolved
encoding/rlp/rlp.go Outdated Show resolved Hide resolved
encoding/rlp/rlp.go Outdated Show resolved Hide resolved
@gregdhill gregdhill force-pushed the gregdhill:web3 branch from b0624f3 to d994e44 Sep 20, 2019
@gregdhill gregdhill requested review from seanyoung and silasdavis Sep 20, 2019
@gregdhill gregdhill added the area/evm label Sep 20, 2019
@gregdhill gregdhill referenced this pull request Sep 20, 2019
@gregdhill gregdhill force-pushed the gregdhill:web3 branch 2 times, most recently from 6eaa1ba to 308f890 Sep 23, 2019
@gregdhill gregdhill referenced this pull request Sep 24, 2019
@gregdhill gregdhill force-pushed the gregdhill:web3 branch 7 times, most recently from 1821bdc to 1cf41bc Sep 25, 2019
Copy link
Contributor

left a comment

Really solid work.

Only important change is to not double-transfer value.

acm/balance/balance.go Outdated Show resolved Hide resolved
acm/balance/balance.go Outdated Show resolved Hide resolved
docs/reference/web3.md Show resolved Hide resolved
encoding/rlp/rlp_test.go Outdated Show resolved Hide resolved
execution/state/events.go Outdated Show resolved Hide resolved
execution/contexts/call_context.go Outdated Show resolved Hide resolved
protobuf/txs.proto Outdated Show resolved Hide resolved
txs/envelope.go Outdated Show resolved Hide resolved
txs/tx.go Outdated Show resolved Hide resolved
@gregdhill gregdhill force-pushed the gregdhill:web3 branch 2 times, most recently from efa5ff2 to 37289f5 Sep 26, 2019
@gregdhill gregdhill force-pushed the gregdhill:web3 branch from 37289f5 to 212a048 Sep 26, 2019
Signed-off-by: Gregory Hill <greg.hill@monax.io>
gregdhill added 7 commits Sep 13, 2019
Signed-off-by: Gregory Hill <greg.hill@monax.io>
Signed-off-by: Gregory Hill <greg.hill@monax.io>
Signed-off-by: Gregory Hill <greg.hill@monax.io>
fix getBlockByHash and add test

Signed-off-by: Gregory Hill <greg.hill@monax.io>
Signed-off-by: Gregory Hill <greg.hill@monax.io>
fixup unnecessary casts and encoding
split out hex encoding helpers, add tests
use more constants, add todos

Signed-off-by: Gregory Hill <greg.hill@monax.io>
Signed-off-by: Gregory Hill <greg.hill@monax.io>
@gregdhill gregdhill force-pushed the gregdhill:web3 branch from 4ca5b02 to 83a4f80 Sep 26, 2019
@silasdavis silasdavis merged commit b27d691 into hyperledger:master Sep 26, 2019
3 checks passed
3 checks passed
Test
Details
Docker
Details
DCO DCO
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.