AssetTransfer Private - Incorrect Endorsement Policy #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbwhite
force-pushed
the
relmain/private-data-policy
branch
2 times, most recently
from
72eb010
to
2cb2f1f
Compare
|
This is a good change - fix is coming to Fabric: |
For the asset transfer example (https://hyperledger-fabric.readthedocs.io/en/release-2.5/private_data_tutorial.html#pd-use-case) the are three private data collections, one per org and one shared between the orgs. The shared collection didn't have an endorsement policy so inheritted the chaincodes; this was specifically set away from the default to be OR(Org1MSP,Org2MSP). The documentation says this is to ensure that either organization can create and asset. However this isn't really necassary, the endorsement policy should be lowest level; so this PR moves the endorsement policy to the collection. The documentation does I believe lead to a false understanding Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
relmain/private-data-policy
branch
from
2cb2f1f
to
f6becc2
Compare
denyeart
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the asset transfer example (https://hyperledger-fabric.readthedocs.io/en/release-2.5/private_data_tutorial.html#pd-use-case) there are three private data collections, one per org and one shared between the orgs.
The shared collection didn't have an endorsement policy so inherited the chaincodes; this was specifically set away from the default to be OR(Org1MSP,Org2MSP). The documentation says this is to ensure that either organization can create an asset. Whilst this is strictly correct, it is misleading - it doesn't need to be a chaincode wide policy, but specifically to the shared collection.
Therefore it is better to leave the chaincode policy at its default and move the specific policy down to the collection.
With the context of this example as coded, this is exactly functionally the same - but gives a more accurate impression.