Skip to content

Commit 124df5f

Browse files
committed
Remove unnecessary export and CHAINTOOL_URL
... and minor reformatting of docker build calls FAB-14777 #done Change-Id: Id36b4130062777c47c440164ffbea9259878ed73 Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>
1 parent d0ac194 commit 124df5f

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

Makefile

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,6 @@ GO_LDFLAGS = $(patsubst %,-X $(PKGNAME)/common/metadata.%,$(METADATA_VAR))
8686

8787
GO_TAGS ?=
8888

89-
CHAINTOOL_URL ?= https://nexus.hyperledger.org/content/repositories/releases/org/hyperledger/fabric/hyperledger-fabric/chaintool-$(CHAINTOOL_RELEASE)/hyperledger-fabric-chaintool-$(CHAINTOOL_RELEASE).jar
90-
91-
export GO_LDFLAGS GO_TAGS
92-
9389
EXECUTABLES ?= go docker git curl
9490
K := $(foreach exec,$(EXECUTABLES),\
9591
$(if $(shell which $(exec)),some string,$(error "No $(exec) in PATH: Check dependencies")))
@@ -257,12 +253,11 @@ $(BUILD_DIR)/images/baseos/$(DUMMY):
257253
@echo "Docker: building $(TARGET) image"
258254
$(DBUILD) -f images/peer/Dockerfile \
259255
--target base \
260-
--build-arg GO_VER=${GO_VER} --build-arg ALPINE_VER=${ALPINE_VER} \
256+
--build-arg GO_VER=${GO_VER} \
257+
--build-arg ALPINE_VER=${ALPINE_VER} \
261258
-t $(DOCKER_NS)/fabric-$(TARGET) images/peer
262-
docker tag $(DOCKER_NS)/fabric-$(TARGET) \
263-
$(DOCKER_NS)/fabric-$(TARGET):$(BASE_VERSION)
264-
docker tag $(DOCKER_NS)/fabric-$(TARGET) \
265-
$(DOCKER_NS)/fabric-$(TARGET):$(DOCKER_TAG)
259+
docker tag $(DOCKER_NS)/fabric-$(TARGET) $(DOCKER_NS)/fabric-$(TARGET):$(BASE_VERSION)
260+
docker tag $(DOCKER_NS)/fabric-$(TARGET) $(DOCKER_NS)/fabric-$(TARGET):$(DOCKER_TAG)
266261
@touch $@
267262

268263
$(BUILD_DIR)/images/ccenv/$(DUMMY): BUILD_ARGS=--build-arg CHAINTOOL_RELEASE=${CHAINTOOL_RELEASE} \
@@ -273,13 +268,12 @@ $(BUILD_DIR)/images/%/$(DUMMY):
273268
$(eval TARGET = ${patsubst $(BUILD_DIR)/images/%/$(DUMMY),%,${@}})
274269
@echo "Docker: building $(TARGET) image"
275270
$(DBUILD) -f images/$(TARGET)/Dockerfile \
276-
--build-arg GO_VER=${GO_VER} --build-arg ALPINE_VER=${ALPINE_VER} \
271+
--build-arg GO_VER=${GO_VER} \
272+
--build-arg ALPINE_VER=${ALPINE_VER} \
277273
${BUILD_ARGS} \
278274
-t $(DOCKER_NS)/fabric-$(TARGET) .
279-
docker tag $(DOCKER_NS)/fabric-$(TARGET) \
280-
$(DOCKER_NS)/fabric-$(TARGET):$(BASE_VERSION)
281-
docker tag $(DOCKER_NS)/fabric-$(TARGET) \
282-
$(DOCKER_NS)/fabric-$(TARGET):$(DOCKER_TAG)
275+
docker tag $(DOCKER_NS)/fabric-$(TARGET) $(DOCKER_NS)/fabric-$(TARGET):$(BASE_VERSION)
276+
docker tag $(DOCKER_NS)/fabric-$(TARGET) $(DOCKER_NS)/fabric-$(TARGET):$(DOCKER_TAG)
283277
@touch $@
284278

285279
# builds release packages for the host platform

0 commit comments

Comments
 (0)