[FAB-13469] consistently use 127.0.0.1

localhost can resolve to ::1 in some network environments so avoid that
by using 127.0.0.1. Also, when getting a connection fails, we shouldn't
try to close it.

Change-Id: I617357abb1d5d29514634b3e3ad59d93feb8429a
Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>

Author: sykesm

cmd/common/comm/client_test.go

@@ -17,6 +17,7 @@ import (
 
 	"github.com/hyperledger/fabric/core/comm"
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestTLSClient(t *testing.T) {
@@ -34,9 +35,9 @@ func TestTLSClient(t *testing.T) {
 	cl, err := NewClient(conf)
 	assert.NoError(t, err)
 	_, port, _ := net.SplitHostPort(srv.Address())
-	dial := cl.NewDialer(net.JoinHostPort("localhost", port))
+	dial := cl.NewDialer(net.JoinHostPort("127.0.0.1", port))
 	conn, err := dial()
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	conn.Close()
 }
 
@@ -63,9 +64,9 @@ func TestNonTLSClient(t *testing.T) {
 	cl, err := NewClient(conf)
 	assert.NoError(t, err)
 	_, port, _ := net.SplitHostPort(srv.Address())
-	dial := cl.NewDialer(fmt.Sprintf("localhost:%s", port))
+	dial := cl.NewDialer(net.JoinHostPort("127.0.0.1", port))
 	conn, err := dial()
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	conn.Close()
 }