FAB-14491 Split out platforms packaging component

The platforms package currently does two things.

1) It provides dockerfile/image generation tools
2) It provides packaging tools

Generally speaking, consumers need only one of the two, or often even a
subset of one of the two.  This is a first step to break out the docker
logic to allow for other, non-docker builders.

Change-Id: I462df12bf73b7dbf15a8717c41fd1b193f1e1fe9
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

Author: Jason Yellick

core/chaincode/exectransaction_test.go

@@ -56,6 +56,7 @@ import (
 	"github.com/hyperledger/fabric/core/policy/mocks"
 	"github.com/hyperledger/fabric/core/scc"
 	"github.com/hyperledger/fabric/core/scc/lscc"
+	"github.com/hyperledger/fabric/internal/peer/packaging"
 	"github.com/hyperledger/fabric/msp"
 	mspmgmt "github.com/hyperledger/fabric/msp/mgmt"
 	msptesttools "github.com/hyperledger/fabric/msp/mgmt/testtools"
@@ -382,7 +383,7 @@ func endTxSimulation(peerInstance *peer.Peer, chainID string, ccid *pb.Chaincode
 // Build a chaincode.
 func getDeploymentSpec(spec *pb.ChaincodeSpec) (*pb.ChaincodeDeploymentSpec, error) {
 	fmt.Printf("getting deployment spec for chaincode spec: %v\n", spec)
-	codePackageBytes, err := platforms.NewRegistry(&golang.Platform{}).GetDeploymentPayload(spec.Type.String(), spec.ChaincodeId.Path)
+	codePackageBytes, err := packaging.NewRegistry(&golang.Platform{}).GetDeploymentPayload(spec.Type.String(), spec.ChaincodeId.Path)
 	if err != nil {
 		return nil, err
 	}

core/chaincode/platforms/mock/platform.go

@@ -36,9 +36,6 @@ var SupportedPlatforms = []Platform{
 // the given platform
 type Platform interface {
 	Name() string
-	ValidatePath(path string) error
-	ValidateCodePackage(code []byte) error
-	GetDeploymentPayload(path string) ([]byte, error)
 	GenerateDockerfile() (string, error)
 	DockerBuildOptions(path string) (util.DockerBuildOptions, error)
 	GetMetadataAsTarEntries(code []byte) ([]byte, error)
@@ -75,28 +72,6 @@ func NewRegistry(platformTypes ...Platform) *Registry {
 	}
 }
 
-func (r *Registry) ValidateSpec(ccType, path string) error {
-	platform, ok := r.Platforms[ccType]
-	if !ok {
-		return fmt.Errorf("Unknown chaincodeType: %s", ccType)
-	}
-	return platform.ValidatePath(path)
-}
-
-func (r *Registry) ValidateDeploymentSpec(ccType string, codePackage []byte) error {
-	platform, ok := r.Platforms[ccType]
-	if !ok {
-		return fmt.Errorf("Unknown chaincodeType: %s", ccType)
-	}
-
-	// ignore empty packages
-	if len(codePackage) == 0 {
-		return nil
-	}
-
-	return platform.ValidateCodePackage(codePackage)
-}
-
 func (r *Registry) GetMetadataProvider(ccType string, codePackage []byte) ([]byte, error) {
 	platform, ok := r.Platforms[ccType]
 	if !ok {
@@ -105,15 +80,6 @@ func (r *Registry) GetMetadataProvider(ccType string, codePackage []byte) ([]byt
 	return platform.GetMetadataAsTarEntries(codePackage)
 }
 
-func (r *Registry) GetDeploymentPayload(ccType, path string) ([]byte, error) {
-	platform, ok := r.Platforms[ccType]
-	if !ok {
-		return nil, fmt.Errorf("Unknown chaincodeType: %s", ccType)
-	}
-
-	return platform.GetDeploymentPayload(path)
-}
-
 func (r *Registry) GenerateDockerfile(ccType, name, version string) (string, error) {
 	platform, ok := r.Platforms[ccType]
 	if !ok {