Skip to content

Commit 7cf8a73

Browse files
committed
[FAB-13934] Add GinkgoRecover to integration tests.
This makes assertion failure more debuggable. Change-Id: I66f8ac8c9b755eaab37f89a10a39c3bfa44ef39a Signed-off-by: Jay Guo <guojiannan1101@gmail.com>
1 parent 0d3e358 commit 7cf8a73

File tree

2 files changed

+21
-6
lines changed

2 files changed

+21
-6
lines changed

integration/e2e/cft_test.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,6 @@ func findLeader(ordererRunners []*ginkgomon.Runner) int {
381381
wg.Add(len(ordererRunners))
382382

383383
findLeader := func(runner *ginkgomon.Runner) int {
384-
defer GinkgoRecover()
385384
Eventually(runner.Err(), time.Minute, time.Second).Should(gbytes.Say("Raft leader changed: 0 -> "))
386385

387386
idBuff := make([]byte, 1)
@@ -396,7 +395,11 @@ func findLeader(ordererRunners []*ginkgomon.Runner) int {
396395

397396
for _, runner := range ordererRunners {
398397
go func(runner *ginkgomon.Runner) {
399-
defer wg.Done()
398+
defer func() {
399+
GinkgoRecover()
400+
wg.Done()
401+
}()
402+
400403
leader := findLeader(runner)
401404
leaders <- leader
402405
}(runner)

integration/e2e/etcdraft_reconfig_test.go

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,10 @@ func assertBlockReception(expectedHeightsPerChannel map[string]int, orderers []*
463463
wg.Add(len(orderers))
464464
for _, orderer := range orderers {
465465
go func(orderer *nwo.Orderer) {
466-
defer wg.Done()
466+
defer func() {
467+
GinkgoRecover()
468+
wg.Done()
469+
}()
467470
waitForBlockReception(orderer, p, n, channelName, blockSeq)
468471
}(orderer)
469472
}
@@ -475,7 +478,10 @@ func assertBlockReception(expectedHeightsPerChannel map[string]int, orderers []*
475478

476479
for channelName, blockSeq := range expectedHeightsPerChannel {
477480
go func(channelName string, blockSeq int) {
478-
defer wg.Done()
481+
defer func() {
482+
GinkgoRecover()
483+
wg.Done()
484+
}()
479485
assertReception(channelName, blockSeq)
480486
}(channelName, blockSeq)
481487
}
@@ -531,7 +537,10 @@ func assertNoErrorsAreLogged(ordererRunners []*ginkgomon.Runner) {
531537

532538
for _, runner := range ordererRunners {
533539
go func(runner *ginkgomon.Runner) {
534-
defer wg.Done()
540+
defer func() {
541+
GinkgoRecover()
542+
wg.Done()
543+
}()
535544
assertNoErrors(runner)
536545
}(runner)
537546
}
@@ -547,7 +556,10 @@ func deployChaincodes(n *nwo.Network, p *nwo.Peer, o *nwo.Orderer, mycc nwo.Chai
547556
"testchannel3": mycc3,
548557
} {
549558
go func(channel string, cc nwo.Chaincode) {
550-
defer wg.Done()
559+
defer func() {
560+
GinkgoRecover()
561+
wg.Done()
562+
}()
551563
nwo.DeployChaincode(n, channel, o, cc, p)
552564
}(channel, chaincode)
553565
}

0 commit comments

Comments
 (0)