Skip to content

Commit 89c9eba

Browse files
committed
[FAB-13303] increase reconciliation test coverage
Change-Id: Iec9457983983787c802d56ce7cddac64f21712ed Signed-off-by: Artem Barger <bartem@il.ibm.com>
1 parent f8c16f7 commit 89c9eba

File tree

1 file changed

+28
-0
lines changed

1 file changed

+28
-0
lines changed

gossip/privdata/reconcile_test.go

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,3 +424,31 @@ func TestReconciliationFailedToCommit(t *testing.T) {
424424
assert.Error(t, err)
425425
assert.Contains(t, err.Error(), "failed to commit")
426426
}
427+
428+
func TestFailuresWhileReconcilingMissingPvtData(t *testing.T) {
429+
committer := &mocks.Committer{}
430+
fetcher := &mocks.ReconciliationFetcher{}
431+
committer.On("GetMissingPvtDataTracker").Return(nil, errors.New("failed to obtain missing pvt data tracker"))
432+
433+
r := NewReconciler(committer, fetcher, &ReconcilerConfig{sleepInterval: time.Millisecond * 100, batchSize: 1, IsEnabled: true})
434+
err := r.reconcile()
435+
assert.Error(t, err)
436+
assert.Contains(t, "failed to obtain missing pvt data tracker", err.Error())
437+
438+
committer.Mock = mock.Mock{}
439+
committer.On("GetMissingPvtDataTracker").Return(nil, nil)
440+
r = NewReconciler(committer, fetcher, &ReconcilerConfig{sleepInterval: time.Millisecond * 100, batchSize: 1, IsEnabled: true})
441+
err = r.reconcile()
442+
assert.Error(t, err)
443+
assert.Contains(t, "got nil as MissingPvtDataTracker, exiting...", err.Error())
444+
445+
missingPvtDataTracker := &mocks.MissingPvtDataTracker{}
446+
missingPvtDataTracker.On("GetMissingPvtDataInfoForMostRecentBlocks", mock.Anything).Return(nil, errors.New("failed get missing pvt data for recent blocks"))
447+
448+
committer.Mock = mock.Mock{}
449+
committer.On("GetMissingPvtDataTracker").Return(missingPvtDataTracker, nil)
450+
r = NewReconciler(committer, fetcher, &ReconcilerConfig{sleepInterval: time.Millisecond * 100, batchSize: 1, IsEnabled: true})
451+
err = r.reconcile()
452+
assert.Error(t, err)
453+
assert.Contains(t, "failed get missing pvt data for recent blocks", err.Error())
454+
}

0 commit comments

Comments
 (0)