Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[FAB-10221] Use EventuallyWithOffset in execute
When the assertions in execute fail, they're attributed to execute
instead of the caller. That makes debugging more difficult than it
should be.

Change-Id: I0a0f145247b444844b96e0f5540c062931c60633
Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>
  • Loading branch information
sykesm committed May 18, 2018
1 parent c6d0e6c commit 9387247
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions integration/world/components.go
Expand Up @@ -85,6 +85,6 @@ func (c *Components) Zookeeper(id int, network *docker.Network) *runner.Zookeepe

func execute(r ifrit.Runner) {
p := ifrit.Invoke(r)
Eventually(p.Ready(), 2*time.Second).Should(BeClosed())
Eventually(p.Wait(), 45*time.Second).Should(Receive(BeNil()))
EventuallyWithOffset(1, p.Ready(), 2*time.Second).Should(BeClosed())
EventuallyWithOffset(1, p.Wait(), 45*time.Second).Should(Receive(BeNil()))
}

0 comments on commit 9387247

Please sign in to comment.