FAB-15086 Replace GetMaxBlockFileSize w/ constant

ledgerconfig.GetMaxBlockFileSize returns a
fixed value.  Simply replace with a constant
at place of use in ledgerstorage.

Change-Id: Ib61336d0aaced42d98f8e189725ed007d05cb39f
Signed-off-by: Gari Singh <gari.r.singh@gmail.com>

Author: mastersingh24

core/ledger/ledgerconfig/ledger_config.go

@@ -84,11 +84,6 @@ func GetCouchdbRedologsPath() string {
 	return filepath.Join(GetRootPath(), couchdbRedoLogPath)
 }
 
-// GetMaxBlockfileSize returns maximum size of the block file
-func GetMaxBlockfileSize() int {
-	return 64 * 1024 * 1024
-}
-
 // GetTotalQueryLimit exposes the totalLimit variable
 func GetTotalQueryLimit() int {
 	totalQueryLimit := viper.GetInt(confTotalQueryLimit)

core/ledger/ledgerconfig/ledger_config_test.go

@@ -156,10 +156,6 @@ func TestIsHistoryDBEnabledFalse(t *testing.T) {
 	assert.False(t, updatedValue) //test config returns false
 }
 
-func TestGetMaxBlockfileSize(t *testing.T) {
-	assert.Equal(t, 67108864, GetMaxBlockfileSize())
-}
-
 func setUpCoreYAMLConfig() {
 	//call a helper method to load the core.yaml
 	ledgertestutil.SetupCoreYAMLConfig()

core/ledger/ledgerstorage/store.go

@@ -21,6 +21,8 @@ import (
 	"github.com/pkg/errors"
 )
 
+const maxBlockFileSize = 64 * 1024 * 1024
+
 var logger = flogging.MustGetLogger("ledgerstorage")
 
 // Provider encapusaltes two providers 1) block store provider and 2) and pvt data store provider
@@ -49,7 +51,7 @@ func NewProvider() *Provider {
 	}
 	indexConfig := &blkstorage.IndexConfig{AttrsToIndex: attrsToIndex}
 	blockStoreProvider := fsblkstorage.NewProvider(
-		fsblkstorage.NewConf(ledgerconfig.GetBlockStorePath(), ledgerconfig.GetMaxBlockfileSize()),
+		fsblkstorage.NewConf(ledgerconfig.GetBlockStorePath(), maxBlockFileSize),
 		indexConfig)
 
 	pvtStoreProvider := pvtdatastorage.NewProvider()

core/ledger/ledgerstorage/store_test.go

@@ -123,7 +123,7 @@ func TestStoreWithExistingBlockchain(t *testing.T) {
 	}
 	indexConfig := &blkstorage.IndexConfig{AttrsToIndex: attrsToIndex}
 	blockStoreProvider := fsblkstorage.NewProvider(
-		fsblkstorage.NewConf(ledgerconfig.GetBlockStorePath(), ledgerconfig.GetMaxBlockfileSize()),
+		fsblkstorage.NewConf(ledgerconfig.GetBlockStorePath(), maxBlockFileSize),
 		indexConfig)
 
 	blkStore, err := blockStoreProvider.OpenBlockStore(testLedgerid)