Wire parser into peer's PackageProvider

Also fix downstream bug where the container runtime expects
the ChaincodeContainerInfo type to be uppercase.

FAB-13985 #done

Change-Id: I2d36fbfb6a6352cc6dc1dd0336ea9c47b00405cc
Signed-off-by: Will Lahti <wtlahti@us.ibm.com>

Author: wlahti

core/chaincode/lifecycle/legacy_lifecycle.go

@@ -8,6 +8,7 @@ package lifecycle
 
 import (
 	"fmt"
+	"strings"
 
 	"github.com/hyperledger/fabric/core/common/ccprovider"
 	"github.com/hyperledger/fabric/core/ledger"
@@ -141,7 +142,7 @@ func (l *Lifecycle) ChaincodeContainerInfo(chaincodeName string, qe ledger.Simpl
 		Name:          chaincodeName,
 		Version:       definedChaincode.Version,
 		Path:          ccPackage.Metadata.Path,
-		Type:          ccPackage.Metadata.Type,
+		Type:          strings.ToUpper(ccPackage.Metadata.Type),
 		ContainerType: "DOCKER",
 	}, nil
 }

core/chaincode/lifecycle/legacy_lifecycle_test.go

@@ -43,7 +43,6 @@ var _ = Describe("Lifecycle", func() {
 		})
 
 		Describe("ChaincodeDefinition", func() {
-
 			BeforeEach(func() {
 				err := l.Serializer.Serialize(lifecycle.NamespacesName,
 					"name",
@@ -187,7 +186,7 @@ var _ = Describe("Lifecycle", func() {
 					Name:          "name",
 					Version:       "version",
 					Path:          "fake-path",
-					Type:          "fake-type",
+					Type:          "FAKE-TYPE",
 					ContainerType: "DOCKER",
 				}))
 

peer/node/start.go

@@ -211,6 +211,7 @@ func serve(args []string) error {
 	packageProvider := &persistence.PackageProvider{
 		LegacyPP: &ccprovider.CCInfoFSImpl{},
 		Store:    ccStore,
+		Parser:   ccPackageParser,
 	}
 
 	lifecycleImpl.ChaincodeStore = ccStore