[FAB-12217] fix data race in kafka logger test

Instead of adding serialization to the logger, use the serialized method
in flogging to change the backend writer. It's simpler and safe for
concurrency in the test.

Change-Id: Ife516ada57e3286a61f539bcc6ffcd285e39f65e
Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>

Author: sykesm

orderer/consensus/kafka/logger_test.go

@@ -8,11 +8,13 @@ package kafka
 
 import (
 	"fmt"
+	"os"
 	"testing"
 	"time"
 
 	"github.com/Shopify/sarama"
-	"github.com/hyperledger/fabric/common/flogging/floggingtest"
+	"github.com/hyperledger/fabric/common/flogging"
+	"github.com/onsi/gomega/gbytes"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -137,11 +139,9 @@ func TestLogPossibleKafkaVersionMismatch(t *testing.T) {
 	topic := channelNameForTest(t)
 	partition := int32(0)
 
-	oldLogger := logger
-	defer func() { logger = oldLogger }()
-
-	l, recorder := floggingtest.NewTestLogger(t)
-	logger = l
+	buf := gbytes.NewBuffer()
+	flogging.Global.SetWriter(buf)
+	defer flogging.Global.SetWriter(os.Stderr)
 
 	broker := sarama.NewMockBroker(t, 500)
 	defer broker.Close()
@@ -180,7 +180,7 @@ func TestLogPossibleKafkaVersionMismatch(t *testing.T) {
 	case <-partitionConsumer.Messages():
 		t.Fatalf("did not expect to receive message")
 	case <-time.After(shortTimeout):
-		entries := recorder.MessagesContaining("Kafka.Version specified in the orderer configuration is incorrectly set")
-		assert.NotEmpty(t, entries)
+		t.Logf("buffer:\n%s", buf.Contents())
+		assert.Contains(t, string(buf.Contents()), "Kafka.Version specified in the orderer configuration is incorrectly set")
 	}
 }