[FAB-14324] remove peer.CreateChainFromBlock

Change-Id: I390f94a52d36e5d2651629c907ff27f0918ea1bc
Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>

Author: sykesm

core/peer/peer.go

@@ -457,16 +457,6 @@ func (p *Peer) OpenStore(cid string) (transientstore.Store, error) {
 	return store, nil
 }
 
-func CreateChainFromBlock(
-	cb *common.Block,
-	sccp sysccprovider.SystemChaincodeProvider,
-	deployedCCInfoProvider ledger.DeployedChaincodeInfoProvider,
-	legacyLifecycleValidation plugindispatcher.LifecycleResources,
-	newLifecycleValidation plugindispatcher.CollectionAndLifecycleResources,
-) error {
-	return Default.CreateChainFromBlock(cb, sccp, deployedCCInfoProvider, legacyLifecycleValidation, newLifecycleValidation)
-}
-
 func (p *Peer) CreateChainFromBlock(
 	cb *common.Block,
 	sccp sysccprovider.SystemChaincodeProvider,

core/peer/peer_test.go

@@ -174,7 +174,7 @@ func TestCreateChainFromBlock(t *testing.T) {
 		t.FailNow()
 	}
 
-	err = CreateChainFromBlock(block, nil, &mock.DeployedChaincodeInfoProvider{}, nil, nil)
+	err = Default.CreateChainFromBlock(block, nil, &mock.DeployedChaincodeInfoProvider{}, nil, nil)
 	if err != nil {
 		t.Fatalf("failed to create chain %s", err)
 	}

internal/peer/node/start.go

@@ -216,6 +216,8 @@ func serve(args []string) error {
 	policyMgr := peer.NewChannelPolicyManagerGetter()
 	signingIdentity := mgmt.GetLocalSigningIdentityOrPanic()
 
+	// FIXME: Creating the gossip service has the side effect of starting a bunch
+	// of go routines and registration with the grpc server.
 	gossipService, err := initGossipService(
 		policyMgr,
 		metricsProvider,