Revert - Check status of all proposal responses

This reverts commit d9b03e9.

When applied to master, tests began to fail.

FAB-16149

Signed-off-by: Matthew Sykes <matthew.sykes@gmail.com>
Change-Id: I01b7eed453a62b9858290f58e4880a4bcb7d2d91

Author: sykesm

protoutil/txutils.go

@@ -178,12 +178,11 @@ func CreateSignedTx(
 	// ensure that all actions are bitwise equal and that they are successful
 	var a1 []byte
 	for n, r := range resps {
-		if r.Response.Status < 200 || r.Response.Status >= 400 {
-			return nil, errors.Errorf("proposal response was not successful, error code %d, msg %s", r.Response.Status, r.Response.Message)
-		}
-
 		if n == 0 {
 			a1 = r.Payload
+			if r.Response.Status < 200 || r.Response.Status >= 400 {
+				return nil, errors.Errorf("proposal response was not successful, error code %d, msg %s", r.Response.Status, r.Response.Message)
+			}
 			continue
 		}
 

protoutil/txutils_test.go

@@ -159,39 +159,21 @@ func TestCreateSignedTx(t *testing.T) {
 	})
 	prop.Header = headerBytes
 
-	nonMatchingTests := []struct {
-		responses     []*pb.ProposalResponse
-		expectedError string
-	}{
-		// good responses, but different payloads
-		{
-			[]*pb.ProposalResponse{
-				{Payload: []byte("payload"), Response: &pb.Response{Status: int32(200)}},
-				{Payload: []byte("payload2"), Response: &pb.Response{Status: int32(200)}},
-			},
-			"ProposalResponsePayloads do not match",
-		},
-		// good response followed by bad response
-		{
-			[]*pb.ProposalResponse{
-				{Payload: []byte("payload"), Response: &pb.Response{Status: int32(200)}},
-				{Payload: []byte{}, Response: &pb.Response{Status: int32(500), Message: "failed to endorse"}},
-			},
-			"proposal response was not successful, error code 500, msg failed to endorse",
+	// non-matching responses
+	responses = []*pb.ProposalResponse{{
+		Payload: []byte("payload"),
+		Response: &pb.Response{
+			Status: int32(200),
 		},
-		// bad response followed by good response
-		{
-			[]*pb.ProposalResponse{
-				{Payload: []byte{}, Response: &pb.Response{Status: int32(500), Message: "failed to endorse"}},
-				{Payload: []byte("payload"), Response: &pb.Response{Status: int32(200)}},
-			},
-			"proposal response was not successful, error code 500, msg failed to endorse",
+	}}
+	responses = append(responses, &pb.ProposalResponse{
+		Payload: []byte("payload2"),
+		Response: &pb.Response{
+			Status: int32(200),
 		},
-	}
-	for i, nonMatchingTest := range nonMatchingTests {
-		_, err = protoutil.CreateSignedTx(prop, signID, nonMatchingTest.responses...)
-		assert.EqualErrorf(t, err, nonMatchingTest.expectedError, "Expected non-matching response error '%v' for test %d", nonMatchingTest.expectedError, i)
-	}
+	})
+	_, err = protoutil.CreateSignedTx(prop, signID, responses...)
+	assert.Error(t, err, "Expected error with non-matching responses")
 
 	// no endorsement
 	responses = []*pb.ProposalResponse{{