FAB-16120 Adding IT for MSP inconsistence #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DereckLuo
requested review from
ale-linux,
binhn,
C0rWin,
christo4ferris,
denyeart,
guoger,
jyellick,
kchristidis,
manish-sethi,
mastersingh24,
muralisrini,
sykesm and
yacovm
as code owners
mastersingh24
previously requested changes
Nov 23, 2019
jyellick
reviewed
Dec 2, 2019
There was a problem hiding this comment.
As best as I can tell, this test is verifying that if you set an endorsement policy to require a peer role, for an org which does not have node OUs enabled, that that org won't be able to validly endorse. But it's not at all clear from the description of the test that this is the scenario being tested.
It actually seems like it's testing two scenarios, one, where the policy is not satisfied because the peer's signer cert does not have the peer node OU, and one where the policy is not satisfied because the peer's MSP does not define the peer node OU. It would be nice to explicitly call this out in the test, and to name which orgs/peers are testing which scenarios.
jyellick
suggested changes
Dec 4, 2019
Signed-off-by: Chongxin Luo <Chongxin.Luo@ibm.com>
jyellick
approved these changes
Dec 5, 2019
jyellick
approved these changes
Jan 6, 2020
jyellick
dismissed
mastersingh24’s stale review
The referenced typo has been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chongxin Luo Chongxin.Luo@ibm.com
Type of change
Description
Additional details
Related issues
https://jira.hyperledger.org/browse/FAB-16120