[FAB-17439] Expose peer's MSPID to chaincode as an env var CORE_PEER_MSPID #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindluni
reviewed
Jan 24, 2020
caod123
force-pushed
the
mspid-env-var
branch
from
715ece9
to
0921687
Compare
CORE_PEER_LOCALMSPID Signed-off-by: Danny Cao <dcao@us.ibm.com>
caod123
force-pushed
the
mspid-env-var
branch
from
0921687
to
2d65500
Compare
jyellick
approved these changes
Jan 27, 2020
| @@ -20,6 +20,7 @@ export CORE_PEER_TLS_ENABLED="true" | |||
| export CORE_TLS_CLIENT_CERT_FILE="$ARTIFACTS/client.crt" | |||
| export CORE_TLS_CLIENT_KEY_FILE="$ARTIFACTS/client.key" | |||
| export CORE_PEER_TLS_ROOTCERT_FILE="$ARTIFACTS/root.crt" | |||
| export CORE_PEER_LOCALMSPID="$(jq -r .mspid "$ARTIFACTS/chaincode.json")" | |||
There was a problem hiding this comment.
I'm not opposed to adding this line here -- though it's odd to add it only in the binary external builder and not in the golang one, especially since no chaincode (as yet) consumes this variable.
caod123
added a commit
to caod123/fabric
that referenced
this pull request
Jan 27, 2020
…er#549) CORE_PEER_LOCALMSPID Signed-off-by: Danny Cao <dcao@us.ibm.com>
denyeart
pushed a commit
that referenced
this pull request
Jan 27, 2020
CORE_PEER_LOCALMSPID Signed-off-by: Danny Cao <dcao@us.ibm.com>
jimthematrix
pushed a commit
to jimthematrix/fabric
that referenced
this pull request
May 5, 2022
…er#549) CORE_PEER_LOCALMSPID Signed-off-by: Danny Cao <dcao@us.ibm.com> Signed-off-by: Xin Li <xin.li@swirlds.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
See FAB-17439