Update TX pages for API parity #92
Conversation
awrichar
left a comment
awrichar
left a comment
There was a problem hiding this comment.
Approved, but requested a few small tweaks for this or a follow-up
|
I wasn't sure if |
- Remove deprecated fields from UI panels - Remove TX details - Remove links to TX details in Messages view Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
shorsher
force-pushed
the
tx-fixes
branch
2 times, most recently
from
28f7e4e to
be6b6ba
Compare
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
There was a problem hiding this comment.
Remove block if id is undefined
dechdev
left a comment
dechdev
left a comment
There was a problem hiding this comment.
Looks good, requested one change
src/core/interfaces.ts
Outdated
| error: string; | ||
| id: string; | ||
| status: string; | ||
| subtype: string; |
There was a problem hiding this comment.
error, id, and subtype are all optional (may be undefined)
src/core/interfaces.ts
Outdated
| } | ||
|
|
||
| export interface ITransactionStatus { | ||
| status: string; |
There was a problem hiding this comment.
status (here and in the details) is an enum of Pending/Failed/Succeeded, so might be useful to define that
|
@shorsher I think "Status" is correct as the label for Pending/Succeeded/Failed, but I do think it's confusing as the header for the child objects. Perhaps just "Details" for that header? |
|
|
||
| return ( | ||
| <> | ||
| <Typography fontWeight="bold">{t('status')}</Typography> |
There was a problem hiding this comment.
Commented on the top-level too... but maybe "Details" is a more appropriate header here
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
3 participants
<Slide>and include transaction status objects