Rename tokens "https" plugin to "fftokens" #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name "https" is too generic - the plugin represents a way to map token operations like pool, mint, and transfer into a specific HTTP+websocket protocol. Therefore a specific, unique name is appropriate. Also changed the config key from "connector" to "plugin" (since its purpose is to affect which plugin FireFly loads from the map). Added migration paths for both changes so that the CLI and any existing stacks can have time to be updated. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name "https" is too generic - the plugin represents a way to map token operations
like pool, mint, and transfer into a specific HTTP+websocket protocol. Therefore a
specific, unique name is appropriate.
Also changed the config key from "connector" to "plugin" (since its purpose is to
affect which plugin FireFly loads from the map).
Added migration paths for both changes so that the CLI and any existing stacks can
have time to be updated.