Fix send-to-self for private messages, and add group query URLs #363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when I was only sending to myself, I was still getting data being pushed by FireFly core to DX.
Looks like when we made the identity change to introduce DIDs, we broke the code here:
firefly/internal/privatemessaging/privatemessaging.go
Lines 188 to 191 in 24d075b
Also @hfuss mentioned to me that we've seen problems where the config has to have the full Key specification exactly as it gets resolved by the blockchain connector (so
0xprefix for ethereum, and the fullCN=xyz...syntax for fabric), or things do not work correctly.This PR:
Ownerof aNodeto the signing key of the local org, not the DID