Skip to content

Conversation

@peterbroadhurst
Copy link
Contributor

I noticed that when I was only sending to myself, I was still getting data being pushed by FireFly core to DX.

Looks like when we made the identity change to introduce DIDs, we broke the code here:

if node.Owner == localOrgDID {
l.Debugf("Skipping send of %s for local node %s:%s for group=%s node=%s (%d/%d)", mType, ns, mID, group, node.ID, i+1, len(nodes))
continue
}

Also @hfuss mentioned to me that we've seen problems where the config has to have the full Key specification exactly as it gets resolved by the blockchain connector (so 0x prefix for ethereum, and the full CN=xyz... syntax for fabric), or things do not work correctly.

This PR:

  • Ensures we always use the blockchain connector to get the resolved signing key
  • Compares Owner of a Node to the signing key of the local org, not the DID
  • Adds APIs to query groups, which seemed to be missing

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nguyer nguyer merged commit 611f2a6 into hyperledger:main Dec 20, 2021
@peterbroadhurst peterbroadhurst deleted the pin-only branch December 20, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants