diff --git a/.github/workflows/docker_main.yml b/.github/workflows/docker_main.yml index f3d75c3dc5..46161e9d75 100644 --- a/.github/workflows/docker_main.yml +++ b/.github/workflows/docker_main.yml @@ -22,11 +22,12 @@ jobs: - name: Build run: | - docker build \ + make DOCKER_ARGS='\ --label commit=$GITHUB_SHA \ --label build_date=$(date -u +"%Y-%m-%dT%H:%M:%SZ") \ --label tag=${{ steps.build_tag_generator.outputs.BUILD_TAG }} \ - --tag ghcr.io/hyperledger/firefly:${{ steps.build_tag_generator.outputs.BUILD_TAG }} . + --tag ghcr.io/hyperledger/firefly:${{ steps.build_tag_generator.outputs.BUILD_TAG }}' \ + docker - name: Tag release run: docker tag ghcr.io/hyperledger/firefly:${{ steps.build_tag_generator.outputs.BUILD_TAG }} ghcr.io/hyperledger/firefly:head diff --git a/.github/workflows/docker_release.yml b/.github/workflows/docker_release.yml index d03b96c670..194a51ba42 100644 --- a/.github/workflows/docker_release.yml +++ b/.github/workflows/docker_release.yml @@ -12,19 +12,14 @@ jobs: with: fetch-depth: 0 - - name: Filter Helm Releases - run: | - echo "Detected that GitHub release is for the Helm chart... aborting this build as a result." - exit 1 - if: startsWith(github.ref, 'refs/tags/helm-v') - - name: Build run: | - docker build \ + make DOCKER_ARGS='\ --label commit=$GITHUB_SHA \ --label build_date=$(date -u +"%Y-%m-%dT%H:%M:%SZ") \ --label tag=${GITHUB_REF##*/} \ - --tag ghcr.io/hyperledger/firefly:${GITHUB_REF##*/} . + --tag ghcr.io/hyperledger/firefly:${GITHUB_REF##*/}' \ + docker - name: Tag release if: github.event.action == 'released' diff --git a/Makefile b/Makefile index 4d8c7924c2..ff217030ed 100644 --- a/Makefile +++ b/Makefile @@ -90,4 +90,4 @@ swagger: manifest: ./manifestgen.sh docker: - ./docker_build.sh \ No newline at end of file + ./docker_build.sh $(DOCKER_ARGS) \ No newline at end of file diff --git a/docker_build.sh b/docker_build.sh index 42e5de8c28..45b65f5425 100755 --- a/docker_build.sh +++ b/docker_build.sh @@ -16,6 +16,7 @@ # See the License for the specific language governing permissions and # limitations under the License. +echo $@ if [[ ! -x `which jq` ]]; then echo "Please install \"jq\" to continue"; exit 1; fi @@ -44,4 +45,5 @@ docker build \ --build-arg BASE_TAG=$BASE_TAG \ --build-arg UI_TAG=$UI_TAG \ --build-arg UI_RELEASE=$UI_RELEASE \ + $@ \ . \ No newline at end of file