-
Notifications
You must be signed in to change notification settings - Fork 242
Prometheus metrics #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus metrics #503
Conversation
Codecov Report
@@ Coverage Diff @@
## main #503 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 267 275 +8
Lines 15429 15694 +265
==========================================
+ Hits 15429 15694 +265
Continue to review full report at Codecov.
|
74d71c1 to
86316b5
Compare
Signed-off-by: David Echelberger <eberger727@gmail.com>
Signed-off-by: David Echelberger <eberger727@gmail.com>
86316b5 to
120c741
Compare
Signed-off-by: David Echelberger <eberger727@gmail.com>
Signed-off-by: David Echelberger <eberger727@gmail.com>
peterbroadhurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thought - not a requirement at all for you to change the PR, but just something that might make a change like this easier in the future.
Signed-off-by: David Echelberger <eberger727@gmail.com>
…-metrics Signed-off-by: David Echelberger <eberger727@gmail.com>
onelapahead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very quickly glanced and lgtm, talked with @eberger727 and it would be nice to include tags on the messages and token transfer counters to keep track of number of messages / transfers btwn pairs of members i.e. to and from tags on each counter.
Not a requirement for this massive improvement around metrics, but will open a follow up issue for it.
Prometheus metrics for the following events:
Broadcast & Private Message:
Token Mint, Transfer, and Burn: