Skip to content

Conversation

@dechdev
Copy link
Contributor

@dechdev dechdev commented Feb 9, 2022

Prometheus metrics for the following events:

Broadcast & Private Message:

  • Submitted
  • Confirmed
  • Rejected
  • Histogram

Token Mint, Transfer, and Burn:

  • Submitted
  • Confirmed
  • Rejected
  • Histogram

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #503 (f887a45) into main (7c31413) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              main      #503    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          267       275     +8     
  Lines        15429     15694   +265     
==========================================
+ Hits         15429     15694   +265     
Impacted Files Coverage Δ
internal/assets/manager.go 100.00% <100.00%> (ø)
internal/assets/token_transfer.go 100.00% <100.00%> (ø)
internal/batchpin/batchpin.go 100.00% <100.00%> (ø)
internal/broadcast/manager.go 100.00% <100.00%> (ø)
internal/broadcast/message.go 100.00% <100.00%> (ø)
internal/events/aggregator.go 100.00% <100.00%> (ø)
internal/events/event_manager.go 100.00% <100.00%> (ø)
internal/events/operation_update.go 100.00% <100.00%> (ø)
internal/events/tokens_transferred.go 100.00% <100.00%> (ø)
internal/metrics/batch_pin.go 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c31413...f887a45. Read the comment docs.

@dechdev dechdev force-pushed the prometheus-metrics branch from 74d71c1 to 86316b5 Compare February 9, 2022 21:44
Signed-off-by: David Echelberger <eberger727@gmail.com>
Signed-off-by: David Echelberger <eberger727@gmail.com>
Signed-off-by: David Echelberger <eberger727@gmail.com>
Signed-off-by: David Echelberger <eberger727@gmail.com>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thought - not a requirement at all for you to change the PR, but just something that might make a change like this easier in the future.

Signed-off-by: David Echelberger <eberger727@gmail.com>
…-metrics

Signed-off-by: David Echelberger <eberger727@gmail.com>
Copy link
Contributor

@onelapahead onelapahead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very quickly glanced and lgtm, talked with @eberger727 and it would be nice to include tags on the messages and token transfer counters to keep track of number of messages / transfers btwn pairs of members i.e. to and from tags on each counter.

Not a requirement for this massive improvement around metrics, but will open a follow up issue for it.

@dechdev dechdev merged commit fce32d6 into hyperledger:main Feb 11, 2022
@dechdev dechdev deleted the prometheus-metrics branch February 11, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants