Skip to content

Conversation

@onelapahead
Copy link
Contributor

This would allow us remove the bits in the helm chart that download apk packages at runtime. This is a best practice for Docker images and would allow enterprises using the chart / images to use them within their networks where they do not allow for public internet access.

Obviously the chart could simply use different images (however for migrations we take advantage of the fact that the migration are bundled into the firefly image), however I wanted to get the community's feedback on taking the hit in the image size being slightly larger for the sake of operational simplicity.

Signed-off-by: hfuss <haydenfuss@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #521 (73a4ef7) into main (2ad92fa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #521   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          275       275           
  Lines        15812     15812           
=========================================
  Hits         15812     15812           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad92fa...73a4ef7. Read the comment docs.

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hfuss - I agree these utilities seem to tip clearly over the usefulness vs. bloat compromise.

I could imagine use maintaining two tag prefixes at some point in FireFly's future, for a runtime vs. utility image. However, I don't think that's justified yet.

@peterbroadhurst peterbroadhurst merged commit 57c43c4 into hyperledger:main Feb 14, 2022
@peterbroadhurst peterbroadhurst deleted the utilities-in-dockerfile branch February 14, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants