Do not return an error from status if node lookup fails #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
peterbroadhurst
commented
Mar 25, 2022
| status.Org.DID = org.DID | ||
|
|
||
| node, _, err := or.identity.CachedIdentityLookup(ctx, fmt.Sprintf("%s%s", fftypes.FireFlyNodeDIDPrefix, status.Node.Name)) | ||
| node, _, err := or.identity.CachedIdentityLookupNilOK(ctx, fmt.Sprintf("%s%s", fftypes.FireFlyNodeDIDPrefix, status.Node.Name)) |
Contributor
Author
There was a problem hiding this comment.
This is the key change
Codecov Report
@@ Coverage Diff @@
## main #630 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 311 311
Lines 18838 18842 +4
=========================================
+ Hits 18838 18842 +4
Continue to review full report at Codecov.
|
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
nguyer
approved these changes
Mar 25, 2022
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
nguyer
reviewed
Mar 25, 2022
peterbroadhurst
force-pushed
the
status-error
branch
from
72f86b7 to
124a0ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
v0.14.0if you register your org (only), and then call/api/v1/statusyou receive: