-
Notifications
You must be signed in to change notification settings - Fork 242
surface URI as parameter for token mint #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #879 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 299 299
Lines 19500 19501 +1
=======================================
+ Hits 19494 19495 +1
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
|
This is a good candidate for a |
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
peterbroadhurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like the approach that for uri we use the fully API modeled field to allow it to be set on mint.
I note that for other actions (pool creation, approval) we have an opaque config that is passed through FireFly to the Token connector, allowing extensibility without needing to change Core.
Feels like to avoid needing future changes in Core for other things that might need to be customized on mint/burn/transfer, we should add a similar pass-through field now?
Would you mind adding that into this PR before we merge?
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
peterbroadhurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding that @shorsher
These changes also include added an optional
configparameter, that is passed to directly to the token connectors without validation.