Skip to content

Conversation

@shorsher
Copy link
Member

@shorsher shorsher commented Jun 24, 2022

These changes also include added an optional config parameter, that is passed to directly to the token connectors without validation.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #879 (04cd951) into main (52e7744) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #879   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         299      299           
  Lines       19500    19501    +1     
=======================================
+ Hits        19494    19495    +1     
  Misses          5        5           
  Partials        1        1           
Impacted Files Coverage Δ
internal/tokens/fftokens/fftokens.go 99.55% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e7744...04cd951. Read the comment docs.

@shorsher
Copy link
Member Author

This is a good candidate for a 1.0.3 release.

shorsher added 2 commits July 5, 2022 13:31
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the approach that for uri we use the fully API modeled field to allow it to be set on mint.

I note that for other actions (pool creation, approval) we have an opaque config that is passed through FireFly to the Token connector, allowing extensibility without needing to change Core.

Feels like to avoid needing future changes in Core for other things that might need to be customized on mint/burn/transfer, we should add a similar pass-through field now?

Would you mind adding that into this PR before we merge?

Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding that @shorsher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants