Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC for Grid Product #5

Merged
merged 38 commits into from Sep 6, 2019
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
2397354
Add RFC for Grid Product
adeebahmed Mar 25, 2019
9197d8d
Add line wrap 80 characters
adeebahmed Mar 26, 2019
8094733
Fix code indents
adeebahmed Mar 26, 2019
a073cf2
Add RFC header
adeebahmed Mar 26, 2019
6e810c5
Change scheme to "schema"
adeebahmed Apr 24, 2019
4e68eb1
Refactor RFC scope
adeebahmed May 13, 2019
e549cef
Add type field to product
adeebahmed May 24, 2019
600916d
Add owner to product_payload.proto
adeebahmed May 29, 2019
ba55b58
Remove owner from product_payload.proto
adeebahmed May 29, 2019
7b19c91
Add gtin validation, and word wrap
adeebahmed May 30, 2019
fe9abd5
Fix line wrapping on links
adeebahmed May 30, 2019
2dffc1e
Fix typo
adeebahmed Jun 13, 2019
a5f704d
Fix product word wrap and white space issues
vaporos Jul 9, 2019
d4c86be
Merge pull request #2 from Cargill/fix-product-word-wrapping
adeebahmed Jul 9, 2019
2c42a45
Add Dave's comments & refactor 'type'
adeebahmed Jul 19, 2019
8c31847
Make examples more generic & wording adjustments
adeebahmed Jul 24, 2019
3a5944e
Refactor identifier to product_id & other fixes
adeebahmed Jul 25, 2019
70ebd7d
Fix word wrap
adeebahmed Jul 26, 2019
a44d56e
Fix typo
adeebahmed Jul 31, 2019
463baf7
Refactor product_type to product_namespace
adeebahmed Aug 2, 2019
fe51a64
Add formatting improvments
adeebahmed Aug 2, 2019
457fc43
Refactor missed words
adeebahmed Aug 2, 2019
e4c825c
Add line wrap 80
adeebahmed Aug 5, 2019
36969e9
Fix line wrap errors
adeebahmed Aug 5, 2019
276614f
Fix bullet point
adeebahmed Aug 5, 2019
53636a8
Fix bullet point
adeebahmed Aug 5, 2019
3e16de6
Fix typos
adeebahmed Aug 7, 2019
8703eeb
Add missing timestamp field to product payload
Patrick-Erichsen Aug 12, 2019
b9b0c95
Merge pull request #3 from target/product_payload_timestmap
adeebahmed Aug 12, 2019
c6225a6
Add details & fix typos
adeebahmed Aug 12, 2019
0736b9f
Integrate more comments
adeebahmed Aug 12, 2019
b34cd7e
Fix formatting
adeebahmed Aug 13, 2019
7ecc588
Fix bullet point lines
adeebahmed Aug 13, 2019
fbedec0
Incorporate James's comments
adeebahmed Aug 14, 2019
5cbcb31
Fix formatting
adeebahmed Aug 16, 2019
0cec18f
Add Jason's comments
adeebahmed Aug 20, 2019
cb45bf5
Add Gena's comment
adeebahmed Aug 20, 2019
d6305b8
Incorporate feedback from hel-leithy's comments
adeebahmed Aug 29, 2019
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.