Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS Wrapper] Fixed build issues #1664

Open
wants to merge 6 commits into
base: master
from

Conversation

@anastasia-tarasova
Copy link
Contributor

anastasia-tarasova commented Jun 6, 2019

  • Replaced OpenSSL with OpenSSL-Universal
  • Removed CoreBitcoin pod
  • Added logic for Base58 data conversion.
  • Added support of Swift classes in Indy-demoTest
- Removed `CoreBitcoin` pod
- Added a logic for Base58 data conversion.
- Added support of Swift classes in `Indy-demoTest`

Signed-off-by: Anastasia Tarasova <anastasiya.tarasova@dsr-company.com>
@anastasia-tarasova anastasia-tarasova force-pushed the anastasia-tarasova:feature/ios_wrapper_fix branch from a021ed8 to 0e7ea04 Jun 7, 2019
Signed-off-by: Anastasia Tarasova <anastasiya.tarasova@dsr-corporation.com>
@anastasia-tarasova anastasia-tarasova force-pushed the anastasia-tarasova:feature/ios_wrapper_fix branch from 07d0770 to 91355ad Jun 12, 2019
Signed-off-by: Anastasia Tarasova <anastasiya.tarasova@dsr-company.com>
Signed-off-by: Anastasia Tarasova <anastasiya.tarasova@dsr-company.com>
@edynox

This comment has been minimized.

Copy link

edynox commented Jul 11, 2019

Nice! It would be great to include support for Swift 5 here (#1611).

@kdenhartog

This comment has been minimized.

Copy link
Contributor

kdenhartog commented Jul 11, 2019

It looks like this is failing to pass because the CI pipeline is still running XCode 9.2. We would need to update to 10.2 in order to compile this Swift 5 code, and have the CI pipeline pass. @esplinr or @stevengubler do either of you know if someone is able to do this work so we can merge this PR? (I'm not familiar enough with CI pipelines to do the work)

@jovfer jovfer changed the base branch from rc to master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.