Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #2599: Remove nursery lints #3098

Merged
merged 2 commits into from Feb 1, 2023

Conversation

appetrosyan
Copy link
Contributor

Description of the Change

Nursery lints are explicitly disabled. The lints which were enabled as part of clippy::nursery are instead enabled individually.

Issue

Closes #2599

Benefits

Smoother toolchain upgrade process

Possible Drawbacks

New lints have to be explicitly enabled. Migitation:

  • On each upgrade uncomment clippy::nursery and see the effects of new lints.

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
@github-actions github-actions bot added the iroha2 The re-implementation of a BFT hyperledger in RUST label Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #3098 (e05969f) into iroha2-dev (a4d5c9f) will increase coverage by 2.83%.
The diff coverage is 74.76%.

@@              Coverage Diff               @@
##           iroha2-dev    #3098      +/-   ##
==============================================
+ Coverage       62.33%   65.16%   +2.83%     
==============================================
  Files             169      171       +2     
  Lines           31218    33499    +2281     
==============================================
+ Hits            19459    21831    +2372     
+ Misses          11759    11668      -91     
Impacted Files Coverage Δ
cli/src/main.rs 1.09% <0.00%> (ø)
cli/src/torii/mod.rs 27.65% <ø> (ø)
cli/src/torii/utils.rs 75.00% <0.00%> (-9.85%) ⬇️
client_cli/src/main.rs 0.24% <0.00%> (-0.01%) ⬇️
config/base/src/lib.rs 91.57% <ø> (+55.21%) ⬆️
config/src/lib.rs 33.33% <ø> (ø)
config/src/logger.rs 70.21% <ø> (ø)
config/src/path.rs 0.00% <0.00%> (ø)
core/src/lib.rs 100.00% <ø> (ø)
core/src/smartcontracts/isi/block.rs 85.71% <ø> (-3.18%) ⬇️
... and 159 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@appetrosyan appetrosyan self-assigned this Jan 30, 2023
@mversic
Copy link
Contributor

mversic commented Jan 31, 2023

better, because nursery lints, since they are incomplete/not agreed upon/incorrect, can make the code look worse and encourage bad practices among engineers to just to satisfy the linter

@appetrosyan appetrosyan merged commit 448c310 into hyperledger:iroha2-dev Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2 The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants