in consensus ordering avoid vector copying; build fix for g++-7 #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBoldyrev
reviewed
Dec 29, 2019
There was a problem hiding this comment.
generally, in a PR we try to do only one thing. or, if that seems too much hassle, the changes need to be at least related to a single global goal. this does not seem to be the case in this PR. It would be nice to at least split the commits.
Also, the code seems not formatted. Please consider running clang-format-7 with the config in the repo before opening a PR. I do it with help of a git hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Minor optimizations. Remove several vector copyings.
Benefits
Consensus ordering function calls become little faster.
Possible Drawbacks