Skip to content

Conversation

@minghinmatthewlam
Copy link

How this works:

pypoetry/virtualenvs/hyperliquid-python-sdk-y6lYbV5e-py3.10/lib/python3.10/site-packages/pkg_resources-stubs/__init__.pyi:329:79: error: Positional-only
parameters are only supported in Python 3.8 and greater  [syntax]

Copy link
Contributor

@traderben traderben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot drop support for python 3.8 and 3.9. Many users still use those versions

@minghinmatthewlam
Copy link
Author

@traderben I removed it, but if the latest commits require python 3.10 to build, why keep it as part of pyproject.toml instead of having people upgrade versions? Seems strange to allow a version that is not compatible with building the repo.

@traderben
Copy link
Contributor

@traderben I removed it, but if the latest commits require python 3.10 to build, why keep it as part of pyproject.toml instead of having people upgrade versions? Seems strange to allow a version that is not compatible with building the repo.

Which commits require python 3.10? Apologies if something slipped through testing. The project is set up to allow users to use 3.8+, but development requires 3.10

@minghinmatthewlam
Copy link
Author

@traderben I removed it, but if the latest commits require python 3.10 to build, why keep it as part of pyproject.toml instead of having people upgrade versions? Seems strange to allow a version that is not compatible with building the repo.

Which commits require python 3.10? Apologies if something slipped through testing. The project is set up to allow users to use 3.8+, but development requires 3.10

oh ye my bad that's only for developers looking to build this repo, but there's still people using the sdk with older versions, disregard.

@traderben
Copy link
Contributor

I'm unable to install with python 3.8:

AttributeError: cython_sources


  at ~/Library/Application Support/pypoetry/venv/lib/python3.8/site-packages/poetry/installation/chef.py:152 in _prepare
      148│
      149│                 error = ChefBuildError("\n\n".join(message_parts))
      150│
      151│             if error is not None:
    → 152│                 raise error from None
      153│
      154│             return path
      155│
      156│     def _prepare_sdist(self, archive: Path, destination: Path | None = None) -> Path:

Note: This error originates from the build backend, and is likely not a problem with poetry but with pyyaml (6.0) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "pyyaml (==6.0)"'.

Is supporting development with other versions of python important for you? I'm going to approve the other PR that bumps the mypy dependency without changing the supported development version of python

@minghinmatthewlam
Copy link
Author

closign 0.981 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants