Remove vlog file if bootstrap, syncDir or mmap fails #1434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The createVlogFile function creates a new vlog file. The function apart from creating a new file, bootstraps it, syncs it to the disk and mmaps it. If any of the three operations fail, we will end up with a file on the disk but the vlog.maxFid will not be updated. On the next attempt to create the vlog files, we will get a "File already exists" error. This commit fixes this issue by removing the file if createVlogFile encounters any error.
jarifibrahim
requested review from
ashish-goswami and
manishrjain
as code owners
jarifibrahim
commented
Jul 16, 2020
| @@ -1000,14 +1000,26 @@ func (vlog *valueLog) createVlogFile(fid uint32) (*logFile, error) { | |||
| return nil, errFile(err, lf.path, "Create value log file") | |||
| } | |||
|
|
|||
| removeFile := func() { | |||
There was a problem hiding this comment.
Add test for this.
There was a problem hiding this comment.
I tried to add a test by setting ulimit but this will be difficult for two reasons
ulimitis set per process. If I set theulimitfor a test, it might affect other tests too.- It's hard to set the correct
ulimitand the test wouldn't fail even if the limit is off by 1.
ashish-goswami
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ashish-goswami and @manishrjain)
jarifibrahim
pushed a commit
that referenced
this pull request
Jul 17, 2020
The createVlogFile function creates a new vlog file. The function apart from creating a new file, bootstraps it, syncs it to the disk, and mmaps it. If any of the three operations fail, we will end up with a file on the disk but the vlog.maxFid will not be updated. On the next attempt to create the vlog files, we will get a "File already exists" error. This commit fixes this issue by removing the file if createVlogFile encounters any error. Fixes DGRAPH-1930 (cherry picked from commit dfcca75)
jarifibrahim
pushed a commit
that referenced
this pull request
Jul 29, 2020
The createVlogFile function creates a new vlog file. The function apart from creating a new file, bootstraps it, syncs it to the disk, and mmaps it. If any of the three operations fail, we will end up with a file on the disk but the vlog.maxFid will not be updated. On the next attempt to create the vlog files, we will get a "File already exists" error. This commit fixes this issue by removing the file if createVlogFile encounters any error. Fixes DGRAPH-1930
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 17, 2020
The createVlogFile function creates a new vlog file. The function apart from creating a new file, bootstraps it, syncs it to the disk, and mmaps it. If any of the three operations fail, we will end up with a file on the disk but the vlog.maxFid will not be updated. On the next attempt to create the vlog files, we will get a "File already exists" error. This commit fixes this issue by removing the file if createVlogFile encounters any error. Fixes DGRAPH-1930 (cherry picked from commit dfcca75)
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 18, 2020
The createVlogFile function creates a new vlog file. The function apart from creating a new file, bootstraps it, syncs it to the disk, and mmaps it. If any of the three operations fail, we will end up with a file on the disk but the vlog.maxFid will not be updated. On the next attempt to create the vlog files, we will get a "File already exists" error. This commit fixes this issue by removing the file if createVlogFile encounters any error. Fixes DGRAPH-1930 (cherry picked from commit dfcca75)
jarifibrahim
pushed a commit
that referenced
this pull request
Sep 9, 2020
The createVlogFile function creates a new vlog file. The function apart from creating a new file, bootstraps it, syncs it to the disk, and mmaps it. If any of the three operations fail, we will end up with a file on the disk but the vlog.maxFid will not be updated. On the next attempt to create the vlog files, we will get a "File already exists" error. This commit fixes this issue by removing the file if createVlogFile encounters any error. Fixes DGRAPH-1930 (cherry picked from commit dfcca75)
jarifibrahim
pushed a commit
that referenced
this pull request
Sep 10, 2020
The createVlogFile function creates a new vlog file. The function apart from creating a new file, bootstraps it, syncs it to the disk, and mmaps it. If any of the three operations fail, we will end up with a file on the disk but the vlog.maxFid will not be updated. On the next attempt to create the vlog files, we will get a "File already exists" error. This commit fixes this issue by removing the file if createVlogFile encounters any error. Fixes DGRAPH-1930 (cherry picked from commit dfcca75)
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 2, 2020
The createVlogFile function creates a new vlog file. The function apart from creating a new file, bootstraps it, syncs it to the disk, and mmaps it. If any of the three operations fail, we will end up with a file on the disk but the vlog.maxFid will not be updated. On the next attempt to create the vlog files, we will get a "File already exists" error. This commit fixes this issue by removing the file if createVlogFile encounters any error. Fixes DGRAPH-1930
mYmNeo
pushed a commit
to mYmNeo/badger
that referenced
this pull request
Jan 16, 2023
…) (hypermodeinc#1515) The createVlogFile function creates a new vlog file. The function apart from creating a new file, bootstraps it, syncs it to the disk, and mmaps it. If any of the three operations fail, we will end up with a file on the disk but the vlog.maxFid will not be updated. On the next attempt to create the vlog files, we will get a "File already exists" error. This commit fixes this issue by removing the file if createVlogFile encounters any error. Fixes DGRAPH-1930 (cherry picked from commit dfcca75)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
createVlogFilefunction creates a new vlog file. The function apartfrom creating a new file, bootstraps it, syncs it to the disk, and mmaps it.
If any of the three operations fail, we will end up with a file on the
disk but the vlog.maxFid will not be updated.
On the next attempt to create the vlog files, we will get a "File
already exists" error. This commit fixes this issue by removing the file
if
createVlogFileencounters any error.Fixes DGRAPH-1930
This change is