Jump to conversation
Unresolved conversations (4)
@jarifibrahim jarifibrahim Sep 29, 2020
return map of vlog-> count and wal -> count
value.go
@jarifibrahim jarifibrahim Sep 29, 2020
We'll need a test for this.
Outdated
db.go
@jarifibrahim jarifibrahim Sep 29, 2020
Add a comment.
db.go
@jarifibrahim jarifibrahim Sep 29, 2020
Call vlog as logManager
db2_test.go
Resolved conversations (8)
@jarifibrahim jarifibrahim Sep 29, 2020
convert this into a function.
Outdated
value.go
@jarifibrahim jarifibrahim Sep 29, 2020
Remove this.
Outdated
value_test.go
@jarifibrahim jarifibrahim Sep 29, 2020
require.Equal(t, 1, len(vlog)) require.Equal(t, t, len(wal))
value_test.go
@jarifibrahim jarifibrahim Sep 29, 2020
This should not be zero. The value is bigger than value threshold so this pointer should not be zero.
Outdated
value_test.go
@jarifibrahim jarifibrahim Sep 29, 2020
Create the vlog files as well. While closing the DB, if the writeable offset of vlog file is zero, delete the file.
value.go
@jarifibrahim jarifibrahim Sep 29, 2020
This may be incorrect. Why should there be 3 wal files? I would expect one or two. Maybe check if the first WAL file is ahead of the head pointer.
Outdated
db_test.go
@jarifibrahim jarifibrahim Sep 29, 2020
Add a comment about why len should be 0.
db_test.go
@jarifibrahim jarifibrahim Sep 29, 2020
I don't think this test is valid anymore. Maybe add a `TODO(ibrahim): Do we need this test?` and we'll fix it later.
db2_test.go