dependencies version upgrade #1768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
./test.sh succeeded but was requiring a VM with 24Gb RAM (8 vCPUs), otherwise Ubuntu detects out of memory condition and kills some tests. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
status/stale
|
This issue was marked as stale and no activity has occurred since then, therefore it will now be closed. Please, reopen if the issue is still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://discuss.dgraph.io/t/upgrade-go-dependencies-to-fix-included-cve/16109/2
Performed:
go get -t -u ./...to upgrade dependenciesgo get github.com/spf13/cobrato upgade to v1 (the one which includes the CVE)go get github.com/pkg/sftpto use latest sftp versions since v1.10.1 included by dependencies is known to suffer unbounded ressource consumtion as tracked SFTP access blocked and eat too many memory when received message too long pkg/sftp#308. This is fixed since v1.11This change is