Skip to content

Add dropOp mutation to example #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Add dropOp mutation to example #123

merged 1 commit into from
Sep 2, 2020

Conversation

vmrajas
Copy link
Contributor

@vmrajas vmrajas commented Sep 1, 2020

Currently in index.js, there is no example of dropping all data, while keeping the schema.

It was found out that the format of dropOp query is unintuitive. Hence, adding an example to index.js

Related Discuss link: https://discuss.dgraph.io/t/how-do-i-drop-data-using-the-js-library/9744


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@vardhanapoorv vardhanapoorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: A minor comment.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vmrajas)


examples/simple/index.js, line 6 at r1 (raw file):

// Create a client stub.
function newClientStub() {
    return new dgraph.DgraphClientStub("localhost:9080", grpc.credentials.createInsecure());

If we don't pass, we would do that anyway. That's the reason to remove it right? Or it's something else?

@vmrajas vmrajas merged commit a7767cc into master Sep 2, 2020
@vmrajas vmrajas deleted the rajas/add_example branch September 2, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants