BUG: facets returning array

[pjebs]

This bug report may or may not be related to the supposed fix: #3190
#3163

Schema:

	op.Schema = `
		user: bool .
		user.name: string @index(hash) .
		user.email: string @index(hash) .
		user.password: password .
		user.code: string . 
		user.created_at: dateTime .
		user.validated: bool @index(bool) .
		node: bool .
		node.hashid: string @index(hash) . 
		node.owner: uid @reverse . 
		node.parent: uid . 
		node.xdata: string . 
		node.searchable: bool @index(bool) . 
		node.search_title: string @index(term) .
		node.search_synopsis: string @index(fulltext) .
		node.created_at: dateTime .
	`

[pjebs]

query:

q = `
		query withvar($hashid: string) {
			chain(func: eq(node.hashid, $hashid)) @recurse(loop:false) {
				uid
				node.owner
				user.name
				node.hashid
				node.xdata
				node.parent @facets @facets(%s)
			}
		}
	`

[pjebs]

json result:

{
  "chain": [
    {
      "uid": "0x4e27",
      "node.owner": [
        {
          "uid": "0x1",
          "user.name": "alpha"
        }
      ],
      "node.hashid": "jjtn4cdirv",
      "node.xdata": "",
      "node.parent": [
        {
          "uid": "0x4e23",
          "node.owner": [
            {
              "uid": "0x1",
              "user.name": "alpha"
            }
          ],
          "node.hashid": "17t8kc5ig",
          "node.xdata": "",
          "node.parent|facet": "recommended"
        },
        {
          "uid": "0x4e25",
          "node.owner": [
            {
              "uid": "0x1",
              "user.name": "alpha"
            }
          ],
          "node.hashid": "r9t9rc4ip",
          "node.xdata": "",
          "node.parent": [
            {
              "uid": "0x4e23",
              "node.hashid": "17t8kc5ig",
              "node.xdata": "",
              "node.parent|facet": "recommended"
            }
          ],
          "node.parent|facet": "recommended"
        },
        {
          "uid": "0x4e26",
          "node.owner": [
            {
              "uid": "0x1",
              "user.name": "alpha"
            }
          ],
          "node.hashid": "35t8qc8i5",
          "node.xdata": "",
          "node.parent": [
            {
              "uid": "0x4e23",
              "node.hashid": "17t8kc5ig",
              "node.xdata": "",
              "node.parent|facet": "required"
            },
            {
              "uid": "0x4e25",
              "node.hashid": "r9t9rc4ip",
              "node.xdata": "",
              "node.parent|facet": [
                "recommended",
                "recommended"
              ]
            }
          ],
          "node.parent|facet": "required"
        }
      ]
    }
  ]
}

[pjebs]

• This is a recursive query
• You can see "node.parent|facet" should return a string.

The BUG:

The second last "node.parent|facet" returns an array which should not be the case.

[pjebs]

You can see the full query here: https://github.com/thehonestscoop/lemma-chain/blob/master/find_chain.go

[pjebs]

@martinmr, was this bug a side effect of your PR?

[martinmr]

It doesn't seem related. It only affects one of the nodes at the end of the chain. The PR you mentioned affects all of them Can you query the facet on that node directly to see what you get?

[pjebs]

Can you query the facet on that node directly

What does that mean? You mean query that node (eg. "uid": "0x4e25")

[pjebs]

In the meantime, is it safe for me (as a temporary fix) to get the first item from array?

[martinmr]

Yes, that's what I mean. It should be safe to check if you have an array and just get the first one.

[martinmr]

Also, there shouldn't be two @facets directives in your query. At least when I run a similar query using https://docs.dgraph.io/query-language/#facets-on-scalar-predicates I get an error message saying multiple @facets are not allowed. Either you get all the facets or you only get one of them.

[pjebs]

I believe there were good reasons why I had to add the @facets @facets(eq(facet, "required") or eq(facet, "recommended")). Either way it produces no dgraph errors and produces the expected results.

Let me investigate the @facets @facet(%s) issue further since you say it should not be permitted.

@power-f-GOD can you run the query with the ref r9t9rc4ip and 35t8qc8i5 to answer @martinmr's question. You will need to fmt.Println( ) the response back from DGraph.

[power-f-GOD]

Okay. Do you mean to run the query that produced the error again?