[BUG]: Semicolons break fulltext search

[lithdoh]

What version of Dgraph are you using?

dgraph/standalone:latest

Schema:

type Stems  {
	id: ID! 
	link: String! 
	image: String! 
	name: String! @search(by:[fulltext]) 
	length: Int @search 
	rise: Int @search 
	clampDiameter: Float @search 
	steererDiameter: String @search(by:[hash]) 
	color: String @search(by:[hash]) 
	material: String! @search(by:[hash]) 
	price: Float! @search 
	weight: Int @search 
	brand: String! @search(by:[hash]) 
}

Have you tried reproducing the issue with the latest release?

Yes

What is the hardware spec (RAM, CPU, OS)?

Irrelevant

What steps will reproduce the bug?

Make any query that uses fulltext search "alloftext" or "anyoftext" that contains one or more semicolons or backslashes.

Expected behavior and actual result.

When I enter any string containing a semicolon or backslash in the fulltext search, I get the error

“no query string supplied in request”

This is a sample GraphQL query that produces the error

query MyQuery {
  queryItems(filter: {name: {alloftext: "text;with;semicolons"}}) {
    id
    name
    price
  }
}

The issue does not occur when the same query is used in the Dgraph Cloud Explorer for some reason.
I’m using the Docker dgraph/standalone:latest image.

Additional information

The full error message was:

{"errors":[{"message":"no query string supplied in request"}],"extensions":{"tracing":{"version":1,"startTime":"2023-04-04T23:41:00.55157713Z","endTime":"2023-04-04T23:41:00.551966171Z","duration":389041}}}

[mangalaman93]

Hi @lithdoh, would it be possible for you to provide the GraphQL schema that you are using? That would help us easily reproduce this issue and hopefully fix it too.

[lithdoh]

Hi Aman, I have updated the github bug issue with my schema. I have recently discovered that the backslash character "\" has the same result as searching with semicolons.

…

On Fri, Apr 7, 2023 at 4:09 AM Aman Mangal ***@***.***> wrote: Hi @lithdoh <https://github.com/lithdoh>, would it be possible for you to provide the GraphQL schema that you are using? That would help us easily reproduce this issue and hopefully fix it too. — Reply to this email directly, view it on GitHub <#8787 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYAT3Z4XX2JH5GIGL7PR2WDW77YVRANCNFSM6AAAAAAWTLLQRE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mangalaman93]

Everything seems to work for me. I tried the following:

1. Run dgraph from the standalone image

docker run --rm -it -p 8080:8080 dgraph/standalone:latest

2. Setup schema

curl --request POST \
  --url http://localhost:8080/admin \
  --header 'Content-Type: application/json' \
  --data '{"query":"mutation updateGQLSchema($sch: String!) {\n    updateGQLSchema(input: { set: { schema: $sch }}) {\n\t\t\tgqlSchema {\n\t\t\t\tid\n\t\t\t}\n\t\t}\n\t}","operationName":"updateGQLSchema","variables":{"sch":"type Stems  {\n id: ID! \n link: String! \n image: String! \n name: String! @search(by:[fulltext]) \n length: Int @search \n rise: Int @search \n clampDiameter: Float @search \n steererDiameter: String @search(by:[hash]) \n color: String @search(by:[hash]) \n material: String! @search(by:[hash]) \n price: Float! @search \n weight: Int @search \n brand: String! @search(by:[hash]) }"}}'

3. Run query:

curl --request POST \
  --url http://localhost:8080/graphql \
  --header 'Content-Type: application/json' \
  --data '{"query":"query MyQuery {\n  queryStems(filter: {name: {alloftext: \"text;with;semicolons\"}}) {\n    id\n    name\n    price\n  }\n}\n","operationName":"MyQuery","variables":{}}'

I get the following response:

{
  "data": {
    "queryStems": []
  },
  "extensions": {
    "tracing": {
      "version": 1,
      "startTime": "2023-04-17T00:55:38.603403852Z",
      "endTime": "2023-04-17T00:55:38.604507486Z",
      "duration": 1103634,
      "execution": {
        "resolvers": [
          {
            "path": [
              "queryStems"
            ],
            "parentType": "Query",
            "fieldName": "queryStems",
            "returnType": "[Stems]",
            "startOffset": 107965,
            "duration": 991551,
            "dgraph": [
              {
                "label": "query",
                "startOffset": 161326,
                "duration": 936808
              }
            ]
          }
        ]
      }
    }
  }
}
``

[mangalaman93]

Maybe, if you could share the exact steps that you are following, or try the steps that I mentioned here and see whether these steps work for you. Thank you

[lithdoh]

@mangalaman93 Thanks for your reply.

I followed the steps you mentioned exactly and got the same result that you did:

{
    "data": {
        "queryStems": []
    },
    "extensions": {
        "tracing": {
            "version": 1,
            "startTime": "2023-04-17T02:39:26.318015422Z",
            "endTime": "2023-04-17T02:39:26.329421964Z",
            "duration": 11406542,
            "execution": {
                "resolvers": [
                    {
                        "path": [
                            "queryStems"
                        ],
                        "parentType": "Query",
                        "fieldName": "queryStems",
                        "returnType": "[Stems]",
                        "startOffset": 271250,
                        "duration": 11115042,
                        "dgraph": [
                            {
                                "label": "query",
                                "startOffset": 397875,
                                "duration": 10984501
                            }
                        ]
                    }
                ]
            }
        }
    }
}

But immediately after when I tried a similar query like this:

http://localhost:8080/graphql?query=
{ queryStems(filter: {name: {alloftext: "text;with;semicolons"}}) { id name price } }

I got the error:

{"errors":[{"message":"no query string supplied in request"}],"extensions":{"tracing":{"version":1,"startTime":"2023-04-17T02:34:22.367479503Z","endTime":"2023-04-17T02:34:22.367862962Z","duration":383584}}}

Note: Your example escapes the quotations around the search terms: {name: {alloftext: \"text;with;semicolons\"}}, whereas mine uses {name: {alloftext: "text;with;semicolons"}}. I get the same error either way.

I verified that if I try the same query with no semicolons:

http://localhost:8080/graphql?query=
{ queryStems(filter: {name: {alloftext: "textwithoutsemicolons"}}) { id name price } }

I get the correct result of an empty array:

{
    "data": {
        "queryStems": []
    },
    "extensions": {
        "tracing": {
            "version": 1,
            "startTime": "2023-04-17T02:44:44.76351425Z",
            "endTime": "2023-04-17T02:44:44.770049083Z",
            "duration": 6534834,
            "execution": {
                "resolvers": [
                    {
                        "path": [
                            "queryStems"
                        ],
                        "parentType": "Query",
                        "fieldName": "queryStems",
                        "returnType": "[Stems]",
                        "startOffset": 901459,
                        "duration": 5616250,
                        "dgraph": [
                            {
                                "label": "query",
                                "startOffset": 1353375,
                                "duration": 5161500
                            }
                        ]
                    }
                ]
            }
        }
    }
}

[mangalaman93]

Could you give me exact curl commands that you ran?

[lithdoh]

I just copied and pasted the ones you provided.

1. Run dgraph from the standalone image
   docker run --rm -it -p 8080:8080 dgraph/standalone:latest

2. Setup schema

curl --request POST \
  --url http://localhost:8080/admin \
  --header 'Content-Type: application/json' \
  --data '{"query":"mutation updateGQLSchema($sch: String!) {\n    updateGQLSchema(input: { set: { schema: $sch }}) {\n\t\t\tgqlSchema {\n\t\t\t\tid\n\t\t\t}\n\t\t}\n\t}","operationName":"updateGQLSchema","variables":{"sch":"type Stems  {\n id: ID! \n link: String! \n image: String! \n name: String! @search(by:[fulltext]) \n length: Int @search \n rise: Int @search \n clampDiameter: Float @search \n steererDiameter: String @search(by:[hash]) \n color: String @search(by:[hash]) \n material: String! @search(by:[hash]) \n price: Float! @search \n weight: Int @search \n brand: String! @search(by:[hash]) }"}}'

Run query:

curl --request POST \
  --url http://localhost:8080/graphql \
  --header 'Content-Type: application/json' \
  --data '{"query":"query MyQuery {\n  queryStems(filter: {name: {alloftext: \"text;with;semicolons\"}}) {\n    id\n    name\n    price\n  }\n}\n","operationName":"MyQuery","variables":{}}'

Is there some reason why making the query using the endpoint "http://localhost:8080/graphql?query=" would yield different results?

[mangalaman93]

I am thinking that this could have something to do with bash. The shell usually interprets the ? or ``` chars. Could you check that or copy the exact curl command?

[mangalaman93]

If you ran the following on bash, this clearly won't work:

http://localhost:8080/graphql?query=
`{ queryStems(filter: {name: {alloftext: "text;with;semicolons"}}) { id name price } }`

[akon-dey]

It looks like you are using the back quote (`) instead of the single quote (‘).

…

On Tue, Apr 18, 2023 at 4:42 AM Aman Mangal ***@***.***> wrote: If you ran the following on bash, this clearly won't work: http://localhost:8080/graphql?query= `{ queryStems(filter: {name: {alloftext: "text;with;semicolons"}}) { id name price } }` — Reply to this email directly, view it on GitHub <#8787 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH3WHB2KHV4RPPEIIMNCSDXBZ43HANCNFSM6AAAAAAWTLLQRE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[lithdoh]

The backticks were because I used the code formatter in the Github editor when I was writing the reply. Now I am replying by email. So the request URL is http://localhost:8080/graphql?query={ queryStems(filter: {name: {alloftext: "text;with;semicolons"}}) { id name price } } This is not something that you copy and paste in Bash, you would paste this in your browser's address bar.

…

On Tue, Apr 18, 2023 at 4:45 AM Akon Dey ***@***.***> wrote: It looks like you are using the back quote (`) instead of the single quote (‘). On Tue, Apr 18, 2023 at 4:42 AM Aman Mangal ***@***.***> wrote: > If you ran the following on bash, this clearly won't work: > > http://localhost:8080/graphql?query= > `{ queryStems(filter: {name: {alloftext: "text;with;semicolons"}}) { id name price } }` > > — > Reply to this email directly, view it on GitHub > <#8787 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAH3WHB2KHV4RPPEIIMNCSDXBZ43HANCNFSM6AAAAAAWTLLQRE > > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > — Reply to this email directly, view it on GitHub <#8787 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYAT3Z2EKA6G7AGM27MDGM3XBZ5HPANCNFSM6AAAAAAWTLLQRE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mangalaman93]

yeah, I now realize that you are doing it from the browser. The issue is related to this golang/go#25192.

[mangalaman93]

I am not sure how it would work in the browser because the query part of the URL (everything after the ?) is not allowed to have a ;. I am closing this issue for now, if there is anything else, please feel free to re-open it. Thanks for the issue and bringing this to our attention.