Skip to content

Change executable from dgraph to server to match actual executable #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

nii236
Copy link

@nii236 nii236 commented Jun 24, 2016

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Jun 24, 2016

CLA assistant check
All committers have signed the CLA.

@manishrjain
Copy link
Contributor

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


README.md, line 73 [r1] (raw file):

$ mkdir /dgraph/m # Ensure mutations directory exists.
$ server --mutations /dgraph/m --postings /dgraph/p --uids /dgraph/u

The executable is actually called dgraph now. Maybe you have an older version of the code (v0.3 might still call it server).


Comments from Reviewable

@nii236
Copy link
Author

nii236 commented Jun 24, 2016

Thanks for getting back to me! The actual docker image is a month old, which is what those instructions are referring to.

So I guess at this point we either need to update the readme to match what is on Docker hub, or update the Docker image so that the readme is correct.

@manishrjain
Copy link
Contributor

Docker image is built from master tag v0.3. So, you could check out that version of README to get the right names of the binaries.

This particular README shows the latest updates to master. While this is confusing, this is the right behavior​.

We do have a discussion about potentially switching to git flow model. That might help with situations like these.


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@nii236
Copy link
Author

nii236 commented Jun 25, 2016

Makes sense, thank you!

@nii236 nii236 closed this Jun 25, 2016
@nii236 nii236 deleted the patch-1 branch June 25, 2016 00:34
arijitAD pushed a commit that referenced this pull request Oct 15, 2020
* Force CI run

* Re-enabled tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants