Skip to content

Commit now should finish the transaction #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2017
Merged

Commit now should finish the transaction #1884

merged 2 commits into from
Dec 6, 2017

Conversation

peterstace
Copy link

@peterstace peterstace commented Dec 6, 2017 •
edited by manishrjain
Loading

Fixes #1882

This change is Reviewable

@janardhan1993
Copy link
Contributor

:lgtm:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@peterstace peterstace merged commit 4f7d96b into master Dec 6, 2017
@peterstace peterstace mentioned this pull request Dec 6, 2017
Closed
@pawanrawal pawanrawal deleted the peter/commit-now-should-finish-txn branch December 19, 2017 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@janardhan1993 janardhan1993

@pawanrawal pawanrawal

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterstace @janardhan1993 @pawanrawal