Fix for 2338

[janardhan1993]

This change is 

[pawanrawal]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

dgraph/cmd/zero/oracle.go, line 302 at r2 (raw file):

	// There might be race between this proposal trying to commit and predicate
	// move aborting it.
	if s.orc.aborted(src.StartTs) {

Nice fix, though I see that proposeTxn would never return any error. This might have been better handled by the functioning returning an error. Can you maybe add a TODO for this?

---

worker/groups.go, line 501 at r2 (raw file):

			}
			// In case there is no leader, we might miss this state update. So as soon as
			// a node becomes leader it asks for fresh state.

Is it asking or proposing the latest state? I don't follow the problem that we are trying to solve here.

---

Comments from Reviewable

[janardhan1993]

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

---

dgraph/cmd/zero/oracle.go, line 302 at r2 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Nice fix, though I see that proposeTxn would never return any error. This might have been better handled by the functioning returning an error. Can you maybe add a TODO for this?

Done.

---

worker/groups.go, line 501 at r2 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Is it asking or proposing the latest state? I don't follow the problem that we are trying to solve here.

Reverted this change, did this change on a hunch but didn't fix the issue.

---

Comments from Reviewable