Add pbToJson function #251
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 29, 2016
| m = make(map[string]interface{}) | ||
| // This method converts the response from ToProtocolBuffer to an intermediate | ||
| // data structure that can be marshalled to JSON. | ||
| func pbToJson(gr []*graph.Node) map[string][]interface{} { |
houndci-bot
reviewed
Sep 29, 2016
| @@ -971,6 +980,38 @@ func BenchmarkToJSON_100_Director(b *testing.B) { benchmarkToJson("benchmark/di | |||
| func BenchmarkToJSON_1000_Actor(b *testing.B) { benchmarkToJson("benchmark/actors1000.bin", b) } | |||
| func BenchmarkToJSON_1000_Director(b *testing.B) { benchmarkToJson("benchmark/directors1000.bin", b) } | |||
|
|
|||
| func benchmarkToJson2(file string, b *testing.B) { | |||
There was a problem hiding this comment.
func benchmarkToJson2 should be benchmarkToJSON2
houndci-bot
reviewed
Sep 29, 2016
|
|
||
| // This method converts the response from ToProtocolBuffer to an intermediate | ||
| // data structure that can be marshalled to JSON. | ||
| func pbToJson(gr []*graph.Node) map[string][]interface{} { |
houndci-bot
reviewed
Sep 29, 2016
| @@ -386,6 +386,43 @@ func (sg *SubGraph) ToJSON(l *Latency) ([]byte, error) { | |||
| return nil, fmt.Errorf("Runtime should never reach here.") | |||
| } | |||
|
|
|||
| func (sg *SubGraph) ToJSON2(l *Latency) ([]byte, error) { | |||
There was a problem hiding this comment.
exported method SubGraph.ToJSON2 should have comment or be unexported
pawanrawal
added
improvement
and removed
kind/feature
|
After this change the benchmarks for ToJSON aren't that good https://discuss.dgraph.io/t/adding-a-pbtojson-function/938. Hence decided not to go with this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to add a function which can convert the protocol buffer response to a JSON response. This would avoid maintaining both ToJSON and ToProtocolBuffer.
This change is