Issue 2889: Support loading JSON data with live loader #2923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
January 11, 2019 16:11
…generic test data filenames.
… name. Improve live loader messages.
golangcibot
reviewed
Jan 22, 2019
dgraph/cmd/live/run.go
Outdated
| // overwritten, but the attacker could accomplish the same thing by simply omitting the over- | ||
| // written data from the load files in the first place. | ||
| md := md5.New() | ||
| io.WriteString(md, str) |
There was a problem hiding this comment.
Error return value of io.WriteString is not checked (from errcheck)
dgraph/cmd/live/run.go
Outdated
| if opt.keyFields == "" { | ||
| return fmt.Errorf("No uid field found: %+v\n", nqs) | ||
| } | ||
| assignBlankId(nqs) |
There was a problem hiding this comment.
Error return value of assignBlankId is not checked (from errcheck)
| } | ||
| } | ||
|
|
||
| cmd[i].Start() |
There was a problem hiding this comment.
Error return value of (*os/exec.Cmd).Start is not checked (from errcheck)
dgraph/cmd/live/run.go
Outdated
| @@ -21,6 +21,7 @@ import ( | |||
| "bytes" | |||
| "compress/gzip" | |||
| "context" | |||
| "crypto/md5" | |||
There was a problem hiding this comment.
G501: Blacklisted import crypto/md5: weak cryptographic primitive (from gosec)
dgraph/cmd/live/run.go
Outdated
| // here. If an "attacker" crafted a JSON file such that a collision occurs some data may be | ||
| // overwritten, but the attacker could accomplish the same thing by simply omitting the over- | ||
| // written data from the load files in the first place. | ||
| md := md5.New() |
There was a problem hiding this comment.
G401: Use of weak cryptographic primitive (from gosec)
golangcibot
reviewed
Jan 23, 2019
| } | ||
|
|
||
| var opt options | ||
| var tlsConf x.TLSHelperConfig | ||
|
|
||
| var Live x.SubCommand | ||
|
|
||
| var keyFields []string |
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
added 18 commits
January 24, 2019 12:13
…id, just pass the concatenated string to get a real uid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set add support for loading JSON-formatted data using the live loader. Changes:
This change is